From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <James.Bottomley@parallels.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Use queuedata accessors for device handler
Date: Mon, 22 Aug 2011 10:45:05 -0400 [thread overview]
Message-ID: <20110822144505.GA5705@infradead.org> (raw)
In-Reply-To: <201108221335.p7MDZhBm013520@pentland.suse.de>
On Mon, Aug 22, 2011 at 03:35:43PM +0200, Hannes Reinecke wrote:
>
> Starting multipath on a cciss device will cause a kernel
> warning to be triggered. Problem is that we're using the
> ->queuedata field of the request_queue to dereference the
> scsi device; however, for other (non-SCSI) devices this
> points to a totally different structure.
> So we should rather be using accessors here to make
> sure ->queuedata points to a valid sdev.
How do we match to attach a scsi device handler to a non-scsi queue?
I suspect that is the fundamental issue that needs addressing.
next prev parent reply other threads:[~2011-08-22 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 13:35 [PATCH] Use queuedata accessors for device handler Hannes Reinecke
2011-08-22 14:45 ` Christoph Hellwig [this message]
2011-08-22 15:31 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110822144505.GA5705@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@parallels.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox