public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hpsa: do not attempt to read from a write-only register
@ 2011-07-21 18:16 Stephen M. Cameron
  2011-07-21 18:17 ` Stephen Cameron
                   ` (2 more replies)
  0 siblings, 3 replies; 25+ messages in thread
From: Stephen M. Cameron @ 2011-07-21 18:16 UTC (permalink / raw)
  To: james.bottomley
  Cc: linux-scsi, linux-kernel, stephenmcameron, thenzl, akpm, mikem

From: Stephen M. Cameron <scameron@beardog.cce.hp.com>

Most smartarrays tolerate it, but a few new ones don't.
Without this change some newer Smart Arrays will lock up
and i/o will grind to a halt.

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
---
 drivers/scsi/hpsa.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
index 6d8dcd4..7f53cea 100644
--- a/drivers/scsi/hpsa.h
+++ b/drivers/scsi/hpsa.h
@@ -214,7 +214,7 @@ static void SA5_submit_command(struct ctlr_info *h,
 	dev_dbg(&h->pdev->dev, "Sending %x, tag = %x\n", c->busaddr,
 		c->Header.Tag.lower);
 	writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
-	(void) readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
+	(void) readl(h->vaddr + SA5_SCRATCHPAD_OFFSET);
 	h->commands_outstanding++;
 	if (h->commands_outstanding > h->max_outstanding)
 		h->max_outstanding = h->commands_outstanding;

^ permalink raw reply related	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2011-09-02 23:14 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-21 18:16 [PATCH] hpsa: do not attempt to read from a write-only register Stephen M. Cameron
2011-07-21 18:17 ` Stephen Cameron
2011-07-22 22:39 ` Andrew Morton
2011-09-01 15:24 ` [BUG] scsi: hpsa: how to destroy your files Eric Dumazet
2011-09-01 16:07   ` scameron
2011-09-01 16:18     ` Eric Dumazet
2011-09-01 17:40     ` Eric Dumazet
2011-09-01 17:58       ` Roland Dreier
2011-09-01 18:50         ` James Bottomley
2011-09-01 18:58           ` Jesse Barnes
2011-09-01 19:59           ` Jesse Barnes
     [not found]             ` <20110901200349.GO9189@beardog.cce.hp.com>
2011-09-01 20:09               ` Jesse Barnes
2011-09-01 20:44                 ` scameron
2011-09-01 21:50                   ` Jon Mason
2011-09-01 22:01                     ` Eric Dumazet
2011-09-01 22:16                     ` scameron
2011-09-02  5:32                       ` Eric Dumazet
2011-09-02  9:39                     ` Eric Dumazet
2011-09-02 10:08                       ` Eric Dumazet
2011-09-02 15:03                         ` scameron
2011-09-01 19:36         ` Eric Dumazet
2011-09-01 18:01       ` scameron
2011-09-01 19:03         ` scameron
2011-09-02 23:13       ` Andrew Morton
2011-09-02  5:18   ` Mike Galbraith

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox