From: Arnd Bergmann <arnd@arndb.de>
To: James Cloos <cloos@jhcloos.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-mm@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: found __[us]{8,16,32,64} type without #include <linux/types.h>
Date: Fri, 9 Sep 2011 16:29:52 +0200 [thread overview]
Message-ID: <201109091629.52879.arnd@arndb.de> (raw)
In-Reply-To: <m3vct1u75k.fsf@jhcloos.com>
On Friday 09 September 2011, James Cloos wrote:
> All noticed while compiling 3.1-r5:
>
> linux/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h>
This has been around for a long time, I think. I agree that we should do
something about it, but I think we're still looking for a solution that
makes everyone happy.
The script only checks for direct inclusions of types.h, while the drm headers
get it from drm.h. One solution would be to make the script smart enough
to evaluate all indirect header inclusions as well. A more hacky workaround
would be to just treat "drm.h" the same as <linux/types.h>.
Arnd
next prev parent reply other threads:[~2011-09-09 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 14:22 found __[us]{8,16,32,64} type without #include <linux/types.h> James Cloos
2011-09-09 14:29 ` Arnd Bergmann [this message]
2011-09-12 15:27 ` James Cloos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109091629.52879.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cloos@jhcloos.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox