Re: [PATCH 2/5] libsas: fix ->change_queue_{depth|type} for sata devices

Jeff Garzik
2011-09-22T02:30:46Z

On 09/20/2011 06:10 PM, Dan Williams wrote:
> Pass queue_depth change requests to libata, and prevent queue_type
> changes for ATA devices.
>
> Otherwise:
> 1/ we do not honor the libata specific restrictions on the queue depth
> 2/ libsas drivers that do not set sdev->tagged_supported are unable to
> change the queue_depth of ata devices via sysfs
>
> Cc: Tejun Heo<tj@kernel.org>
> Cc: Xiangliang Yu<yuxiangl@marvell.com>
> Cc: Jack Wang<jack_wang@usish.com>
> Cc: Mark Salyzyn<msalyzyn@us.xyratex.com>
> Signed-off-by: Dan Williams<dan.j.williams@intel.com>
> ---
> drivers/ata/libata-core.c | 1 +
> drivers/ata/libata-scsi.c | 44 +++++++++++++++++++++++------------
> drivers/scsi/libsas/sas_scsi_host.c | 11 ++++++++-
> include/linux/libata.h | 2 ++
> 4 files changed, 42 insertions(+), 16 deletions(-)

Acked-by: Jeff Garzik <jgarzik@redhat.com>