From: Christoph Hellwig <hch@infradead.org>
To: Luben Tuikov <ltuikov@yahoo.com>
Cc: James Bottomley <jbottomley@parallels.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND] [PATCH] [SCSI] libsas: Allow expander T-T attachments
Date: Thu, 22 Sep 2011 12:50:14 -0400 [thread overview]
Message-ID: <20110922165014.GA12505@infradead.org> (raw)
In-Reply-To: <1316709696.61028.YahooMailNeo@web31812.mail.mud.yahoo.com>
On Thu, Sep 22, 2011 at 09:41:36AM -0700, Luben Tuikov wrote:
> Allow expander table-to-table attachments for
> expanders that support it.
>
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> ---
> ?drivers/scsi/libsas/sas_expander.c |?? 20 ++++++++++++++------
> ?include/scsi/libsas.h????????????? |??? 3 +++
> ?include/scsi/sas.h???????????????? |?? 14 ++++++++++++--
> ?3 files changed, 29 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
> index f84084b..e8d0115 100644
> --- a/drivers/scsi/libsas/sas_expander.c
> +++ b/drivers/scsi/libsas/sas_expander.c
> @@ -329,6 +329,7 @@ static void ex_assign_report_general(struct domain_device *dev,
> ???? dev->ex_dev.ex_change_count = be16_to_cpu(rg->change_count);
> ???? dev->ex_dev.max_route_indexes = be16_to_cpu(rg->route_indexes);
> ???? dev->ex_dev.num_phys = min(rg->num_phys, (u8)MAX_EXPANDER_PHYS);
This looks completely garbled to me.
next prev parent reply other threads:[~2011-09-22 16:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 4:19 [PATCH] [SCSI] libsas: Allow expander T-T attachments Luben Tuikov
2011-07-28 6:46 ` Jack Wang
2011-07-28 7:52 ` James Bottomley
2011-09-21 0:50 ` Dan Williams
2011-09-22 11:30 ` James Bottomley
2011-09-22 15:04 ` Mark Salyzyn
2011-09-22 15:32 ` [PATCH] [SCSI] libsas panic when single phy disabled on a wide port Mark Salyzyn
2011-09-22 15:50 ` [PATCH] [SCSI] pm8001 DEV_IS_GONE infinite retry Mark Salyzyn
2011-09-26 2:20 ` Jack Wang
2011-09-26 13:15 ` Mark Salyzyn
2011-09-26 14:57 ` [PATCH] [SCSI] pm8001 missing break statements Mark Salyzyn
2011-09-27 4:27 ` Jack Wang
2011-09-30 2:21 ` [PATCH] [SCSI] libsas panic when single phy disabled on a wide port Jack Wang
2011-10-01 1:43 ` Dan Williams
2011-10-03 13:07 ` Mark Salyzyn
2011-10-03 15:58 ` Mark Salyzyn
2011-10-04 8:35 ` Jack Wang
2011-10-04 23:30 ` Dan Williams
2011-10-04 23:38 ` Dan Williams
2011-10-05 12:10 ` Mark Salyzyn
2011-10-06 3:33 ` Jack Wang
2011-09-22 16:30 ` [PATCH] [SCSI] libsas: Allow expander T-T attachments Luben Tuikov
2011-09-22 16:35 ` Luben Tuikov
2011-09-22 17:03 ` Christoph Hellwig
2011-09-22 17:11 ` Luben Tuikov
2011-09-23 18:42 ` Christoph Hellwig
2011-09-23 18:46 ` Alan Cox
2011-09-22 16:41 ` [RESEND] " Luben Tuikov
2011-09-22 16:50 ` Christoph Hellwig [this message]
2011-09-22 17:24 ` Luben Tuikov
2011-09-22 17:32 ` Bart Van Assche
2011-09-22 16:55 ` Mark Salyzyn
2011-09-22 17:19 ` Luben Tuikov
2011-09-22 17:44 ` Mark Salyzyn
2011-09-22 17:48 ` Dan Williams
2011-09-22 17:41 ` Dan Williams
2011-09-23 1:47 ` Jack Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110922165014.GA12505@infradead.org \
--to=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ltuikov@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox