Re: [RESEND] [PATCH] [SCSI] libsas: Allow expander T-T attachments

Luben Tuikov
2011-09-22T17:24:30Z

I've noticed this recently as well. I'm not sure if it is Yahoo or Firefox, or my cutting and pasting from Emacs as opposed to Xterm.

----- Original Message -----
> From: Christoph Hellwig <hch@infradead.org>
> To: Luben Tuikov <ltuikov@yahoo.com>
> Cc: James Bottomley <jbottomley@parallels.com>; "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>; "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
> Sent: Thursday, September 22, 2011 9:50 AM
> Subject: Re: [RESEND] [PATCH] [SCSI] libsas: Allow expander T-T attachments
>
> On Thu, Sep 22, 2011 at 09:41:36AM -0700, Luben Tuikov wrote:
>> Allow expander table-to-table attachments for
>> expanders that support it.
>>
>> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
>> ---
>> ?drivers/scsi/libsas/sas_expander.c |?? 20 ++++++++++++++------
>> ?include/scsi/libsas.h????????????? |??? 3 +++
>> ?include/scsi/sas.h???????????????? |?? 14 ++++++++++++--
>> ?3 files changed, 29 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/scsi/libsas/sas_expander.c
> b/drivers/scsi/libsas/sas_expander.c
>> index f84084b..e8d0115 100644
>> --- a/drivers/scsi/libsas/sas_expander.c
>> +++ b/drivers/scsi/libsas/sas_expander.c
>> @@ -329,6 +329,7 @@ static void ex_assign_report_general(struct
> domain_device *dev,
>> ???? dev->ex_dev.ex_change_count = be16_to_cpu(rg->change_count);
>> ???? dev->ex_dev.max_route_indexes = be16_to_cpu(rg->route_indexes);
>> ???? dev->ex_dev.num_phys = min(rg->num_phys, (u8)MAX_EXPANDER_PHYS);
>
> This looks completely garbled to me.
>