From: Andrew Morton <akpm@google.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: scsi <linux-scsi@vger.kernel.org>,
JBottomley@parallels.com, linux-driver@qlogic.com,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] scsi: fix qla2xxx printk format warning
Date: Fri, 23 Sep 2011 15:50:58 -0700 [thread overview]
Message-ID: <20110923155058.c0a42f68.akpm@google.com> (raw)
In-Reply-To: <4E7D0AF2.7020401@xenotime.net>
On Fri, 23 Sep 2011 15:40:50 -0700
Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> sector_t can be different types, so cast it to its largest
> possible type.
>
> drivers/scsi/qla2xxx/qla_isr.c:1509:5: warning: format '%lx' expects type 'long unsigned int', but argument 5 has type 'sector_t'
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
> drivers/scsi/qla2xxx/qla_isr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- lnx-31-rc7.orig/drivers/scsi/qla2xxx/qla_isr.c
> +++ lnx-31-rc7/drivers/scsi/qla2xxx/qla_isr.c
> @@ -1507,8 +1507,8 @@ qla2x00_handle_dif_error(srb_t *sp, stru
>
> if (k != blocks_done) {
> qla_printk(KERN_WARNING, sp->fcport->vha->hw,
> - "unexpected tag values tag:lba=%x:%lx)\n",
> - e_ref_tag, lba_s);
> + "unexpected tag values tag:lba=%x:%llx)\n",
> + e_ref_tag, (unsigned long long)lba_s);
The patch does more than fix a warning - that's a runtime bug.
next prev parent reply other threads:[~2011-09-23 22:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 22:40 [PATCH] scsi: fix qla2xxx printk format warning Randy Dunlap
2011-09-23 22:50 ` Andrew Morton [this message]
2011-09-24 0:17 ` Giridhar Malavali
2011-09-24 0:16 ` Giridhar Malavali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110923155058.c0a42f68.akpm@google.com \
--to=akpm@google.com \
--cc=JBottomley@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.vasquez@qlogic.com \
--cc=linux-driver@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox