* [PATCH] scsi: fix qla2xxx printk format warning
@ 2011-09-23 22:40 Randy Dunlap
2011-09-23 22:50 ` Andrew Morton
2011-09-24 0:16 ` Giridhar Malavali
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2011-09-23 22:40 UTC (permalink / raw)
To: scsi
Cc: JBottomley, linux-driver, Andrew Vasquez, Andrew Morton,
Linus Torvalds
From: Randy Dunlap <rdunlap@xenotime.net>
sector_t can be different types, so cast it to its largest
possible type.
drivers/scsi/qla2xxx/qla_isr.c:1509:5: warning: format '%lx' expects type 'long unsigned int', but argument 5 has type 'sector_t'
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
drivers/scsi/qla2xxx/qla_isr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- lnx-31-rc7.orig/drivers/scsi/qla2xxx/qla_isr.c
+++ lnx-31-rc7/drivers/scsi/qla2xxx/qla_isr.c
@@ -1507,8 +1507,8 @@ qla2x00_handle_dif_error(srb_t *sp, stru
if (k != blocks_done) {
qla_printk(KERN_WARNING, sp->fcport->vha->hw,
- "unexpected tag values tag:lba=%x:%lx)\n",
- e_ref_tag, lba_s);
+ "unexpected tag values tag:lba=%x:%llx)\n",
+ e_ref_tag, (unsigned long long)lba_s);
return 1;
}
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: fix qla2xxx printk format warning
2011-09-23 22:40 [PATCH] scsi: fix qla2xxx printk format warning Randy Dunlap
@ 2011-09-23 22:50 ` Andrew Morton
2011-09-24 0:17 ` Giridhar Malavali
2011-09-24 0:16 ` Giridhar Malavali
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2011-09-23 22:50 UTC (permalink / raw)
To: Randy Dunlap
Cc: scsi, JBottomley, linux-driver, Andrew Vasquez, Linus Torvalds,
Andrew Morton
On Fri, 23 Sep 2011 15:40:50 -0700
Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> sector_t can be different types, so cast it to its largest
> possible type.
>
> drivers/scsi/qla2xxx/qla_isr.c:1509:5: warning: format '%lx' expects type 'long unsigned int', but argument 5 has type 'sector_t'
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
> drivers/scsi/qla2xxx/qla_isr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- lnx-31-rc7.orig/drivers/scsi/qla2xxx/qla_isr.c
> +++ lnx-31-rc7/drivers/scsi/qla2xxx/qla_isr.c
> @@ -1507,8 +1507,8 @@ qla2x00_handle_dif_error(srb_t *sp, stru
>
> if (k != blocks_done) {
> qla_printk(KERN_WARNING, sp->fcport->vha->hw,
> - "unexpected tag values tag:lba=%x:%lx)\n",
> - e_ref_tag, lba_s);
> + "unexpected tag values tag:lba=%x:%llx)\n",
> + e_ref_tag, (unsigned long long)lba_s);
The patch does more than fix a warning - that's a runtime bug.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: fix qla2xxx printk format warning
2011-09-23 22:50 ` Andrew Morton
@ 2011-09-24 0:17 ` Giridhar Malavali
0 siblings, 0 replies; 4+ messages in thread
From: Giridhar Malavali @ 2011-09-24 0:17 UTC (permalink / raw)
To: Andrew Morton, Randy Dunlap
Cc: scsi, JBottomley@parallels.com, Linux Driver, Andrew Vasquez,
Linus Torvalds, Andrew Morton
Acked-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
>>
>On Fri, 23 Sep 2011 15:40:50 -0700
>Randy Dunlap <rdunlap@xenotime.net> wrote:
>
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>> sector_t can be different types, so cast it to its largest
>> possible type.
>>
>> drivers/scsi/qla2xxx/qla_isr.c:1509:5: warning: format '%lx' expects
>>type 'long unsigned int', but argument 5 has type 'sector_t'
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>> ---
>> drivers/scsi/qla2xxx/qla_isr.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> --- lnx-31-rc7.orig/drivers/scsi/qla2xxx/qla_isr.c
>> +++ lnx-31-rc7/drivers/scsi/qla2xxx/qla_isr.c
>> @@ -1507,8 +1507,8 @@ qla2x00_handle_dif_error(srb_t *sp, stru
>>
>> if (k != blocks_done) {
>> qla_printk(KERN_WARNING, sp->fcport->vha->hw,
>> - "unexpected tag values tag:lba=%x:%lx)\n",
>> - e_ref_tag, lba_s);
>> + "unexpected tag values tag:lba=%x:%llx)\n",
>> + e_ref_tag, (unsigned long long)lba_s);
>
>The patch does more than fix a warning - that's a runtime bug.
>--
>To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: fix qla2xxx printk format warning
2011-09-23 22:40 [PATCH] scsi: fix qla2xxx printk format warning Randy Dunlap
2011-09-23 22:50 ` Andrew Morton
@ 2011-09-24 0:16 ` Giridhar Malavali
1 sibling, 0 replies; 4+ messages in thread
From: Giridhar Malavali @ 2011-09-24 0:16 UTC (permalink / raw)
To: Randy Dunlap, scsi
Cc: JBottomley@parallels.com, Linux Driver, Andrew Vasquez,
Andrew Morton, Linus Torvalds
Acked-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
>>
>From: Randy Dunlap <rdunlap@xenotime.net>
>
>sector_t can be different types, so cast it to its largest
>possible type.
>
>drivers/scsi/qla2xxx/qla_isr.c:1509:5: warning: format '%lx' expects type
>'long unsigned int', but argument 5 has type 'sector_t'
>
>Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>---
> drivers/scsi/qla2xxx/qla_isr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>--- lnx-31-rc7.orig/drivers/scsi/qla2xxx/qla_isr.c
>+++ lnx-31-rc7/drivers/scsi/qla2xxx/qla_isr.c
>@@ -1507,8 +1507,8 @@ qla2x00_handle_dif_error(srb_t *sp, stru
>
> if (k != blocks_done) {
> qla_printk(KERN_WARNING, sp->fcport->vha->hw,
>- "unexpected tag values tag:lba=%x:%lx)\n",
>- e_ref_tag, lba_s);
>+ "unexpected tag values tag:lba=%x:%llx)\n",
>+ e_ref_tag, (unsigned long long)lba_s);
> return 1;
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-09-24 0:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-23 22:40 [PATCH] scsi: fix qla2xxx printk format warning Randy Dunlap
2011-09-23 22:50 ` Andrew Morton
2011-09-24 0:17 ` Giridhar Malavali
2011-09-24 0:16 ` Giridhar Malavali
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox