From: Andrew Morton <akpm00@gmail.com>
To: Mike Miller <mike.miller@hp.com>
Cc: Jens Axboe <axboe@kernel.dk>, LKML <linux-kernel@vger.kernel.org>,
LKML-scsi <linux-scsi@vger.kernel.org>,
scameron@beardog.cce.hp.com, thenzel@redhat.com
Subject: Re: PATCH [1/1] cciss: auto engage scsi subsystem for tape support
Date: Thu, 29 Sep 2011 16:54:17 -0700 [thread overview]
Message-ID: <20110929165417.59fc03c7.akpm00@gmail.com> (raw)
In-Reply-To: <20110916213200.GA24786@beardog.cce.hp.com>
On Fri, 16 Sep 2011 16:32:00 -0500
Mike Miller <mike.miller@hp.com> wrote:
>
> commit 608b0262ce818901b931d7e6534aad375c698924
> Author: Stephen M. Cameron <scameron@beardog.cce.hp.com>
> Date: Mon Aug 29 13:27:46 2011 -0500
>
> cciss: auto engage scsi mid-layer
>
> Acked-by: Mike Miller <mike.miller@hp.com>
Nobody seems to have applied this to anything.
The patch has no signoffs.
The changelog is awful. What are the end-user-visible effects of this
change? How is anyone supposed to tell?
> --- a/drivers/block/cciss_scsi.c
> +++ b/drivers/block/cciss_scsi.c
> @@ -1720,5 +1720,6 @@ static int cciss_eh_abort_handler(struct scsi_cmnd *scsicmd)
> /* If no tape support, then these become defined out of existence */
>
> #define cciss_scsi_setup(cntl_num)
> +#define cciss_engage_scsi(h)
>
> #endif /* CONFIG_CISS_SCSI_TAPE */
cciss #includes .c files? I can't believe you did that :(
next prev parent reply other threads:[~2011-09-29 23:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 21:32 PATCH [1/1] cciss: auto engage scsi subsystem for tape support Mike Miller
2011-09-29 23:54 ` Andrew Morton [this message]
2011-09-30 13:52 ` scameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110929165417.59fc03c7.akpm00@gmail.com \
--to=akpm00@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mike.miller@hp.com \
--cc=scameron@beardog.cce.hp.com \
--cc=thenzel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox