* [PATCH resend] atp870u: use pci_dev->revision
@ 2011-05-13 15:01 Sergei Shtylyov
2011-07-21 15:35 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2011-05-13 15:01 UTC (permalink / raw)
To: linux-scsi, James.Bottomley
This driver uses PCI_CLASS_REVISION instead of PCI_REVISION_ID, so it wasn't
converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65 (PCI: Change all
drivers to use pci_device->revision).
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
This wasn't merged in 2.6.39 time, I hope it can be merged to 2.6.40...
drivers/scsi/atp870u.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/scsi/atp870u.c
===================================================================
--- linux-2.6.orig/drivers/scsi/atp870u.c
+++ linux-2.6/drivers/scsi/atp870u.c
@@ -2583,7 +2583,7 @@ static int atp870u_probe(struct pci_dev
* this than via the PCI device table
*/
if (ent->device == PCI_DEVICE_ID_ARTOP_AEC7610) {
- error = pci_read_config_byte(pdev, PCI_CLASS_REVISION, &atpdev->chip_ver);
+ atpdev->chip_ver = pdev->revision;
if (atpdev->chip_ver < 2)
goto err_eio;
}
@@ -2602,7 +2602,7 @@ static int atp870u_probe(struct pci_dev
base_io &= 0xfffffff8;
if ((ent->device == ATP880_DEVID1)||(ent->device == ATP880_DEVID2)) {
- error = pci_read_config_byte(pdev, PCI_CLASS_REVISION, &atpdev->chip_ver);
+ atpdev->chip_ver = pdev->revision;
pci_write_config_byte(pdev, PCI_LATENCY_TIMER, 0x80);//JCC082803
host_id = inb(base_io + 0x39);
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH resend] atp870u: use pci_dev->revision
2011-05-13 15:01 [PATCH resend] atp870u: use pci_dev->revision Sergei Shtylyov
@ 2011-07-21 15:35 ` Sergei Shtylyov
2011-10-05 14:56 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2011-07-21 15:35 UTC (permalink / raw)
To: linux-scsi, James.Bottomley
This driver uses PCI_CLASS_REVISION instead of PCI_REVISION_ID, so it wasn't
converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65 (PCI: Change all
drivers to use pci_device->revision).
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
This patch wasn't merged in either 2.6.39 or 3.0 time, hopefully it can be
merged to 3.1 at least...
drivers/scsi/atp870u.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/scsi/atp870u.c
===================================================================
--- linux-2.6.orig/drivers/scsi/atp870u.c
+++ linux-2.6/drivers/scsi/atp870u.c
@@ -2583,7 +2583,7 @@ static int atp870u_probe(struct pci_dev
* this than via the PCI device table
*/
if (ent->device == PCI_DEVICE_ID_ARTOP_AEC7610) {
- error = pci_read_config_byte(pdev, PCI_CLASS_REVISION, &atpdev->chip_ver);
+ atpdev->chip_ver = pdev->revision;
if (atpdev->chip_ver < 2)
goto err_eio;
}
@@ -2602,7 +2602,7 @@ static int atp870u_probe(struct pci_dev
base_io &= 0xfffffff8;
if ((ent->device == ATP880_DEVID1)||(ent->device == ATP880_DEVID2)) {
- error = pci_read_config_byte(pdev, PCI_CLASS_REVISION, &atpdev->chip_ver);
+ atpdev->chip_ver = pdev->revision;
pci_write_config_byte(pdev, PCI_LATENCY_TIMER, 0x80);//JCC082803
host_id = inb(base_io + 0x39);
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH resend] atp870u: use pci_dev->revision
2011-07-21 15:35 ` Sergei Shtylyov
@ 2011-10-05 14:56 ` Sergei Shtylyov
0 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2011-10-05 14:56 UTC (permalink / raw)
To: linux-scsi; +Cc: James.Bottomley, akpm
This driver uses PCI_CLASS_REVISION instead of PCI_REVISION_ID, so it wasn't
converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65 (PCI: Change all
drivers to use pci_device->revision).
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
This patch wasn't merged in either 2.6.39, 3.0 or 3.1 time, hopefully it can be
merged to 3.1 at least.
Andrew, the SCSI maintainer seem to ignore this patch, maybe you can queue it?
drivers/scsi/atp870u.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/scsi/atp870u.c
===================================================================
--- linux-2.6.orig/drivers/scsi/atp870u.c
+++ linux-2.6/drivers/scsi/atp870u.c
@@ -2583,7 +2583,7 @@ static int atp870u_probe(struct pci_dev
* this than via the PCI device table
*/
if (ent->device == PCI_DEVICE_ID_ARTOP_AEC7610) {
- error = pci_read_config_byte(pdev, PCI_CLASS_REVISION, &atpdev->chip_ver);
+ atpdev->chip_ver = pdev->revision;
if (atpdev->chip_ver < 2)
goto err_eio;
}
@@ -2602,7 +2602,7 @@ static int atp870u_probe(struct pci_dev
base_io &= 0xfffffff8;
if ((ent->device == ATP880_DEVID1)||(ent->device == ATP880_DEVID2)) {
- error = pci_read_config_byte(pdev, PCI_CLASS_REVISION, &atpdev->chip_ver);
+ atpdev->chip_ver = pdev->revision;
pci_write_config_byte(pdev, PCI_LATENCY_TIMER, 0x80);//JCC082803
host_id = inb(base_io + 0x39);
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH resend] atp870u: use pci_dev->revision
@ 2011-02-11 19:49 Sergei Shtylyov
2011-03-24 19:51 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2011-02-11 19:49 UTC (permalink / raw)
To: linux-scsi, James.Bottomley
This driver uses PCI_CLASS_REVISION instead of PCI_REVISION_ID, so it wasn't
converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65 (PCI: Change all
drivers to use pci_device->revision).
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
Resending with a proper tear line...
drivers/scsi/atp870u.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/scsi/atp870u.c
===================================================================
--- linux-2.6.orig/drivers/scsi/atp870u.c
+++ linux-2.6/drivers/scsi/atp870u.c
@@ -2583,7 +2583,7 @@ static int atp870u_probe(struct pci_dev
* this than via the PCI device table
*/
if (ent->device == PCI_DEVICE_ID_ARTOP_AEC7610) {
- error = pci_read_config_byte(pdev, PCI_CLASS_REVISION, &atpdev->chip_ver);
+ atpdev->chip_ver = pdev->revision;
if (atpdev->chip_ver < 2)
goto err_eio;
}
@@ -2602,7 +2602,7 @@ static int atp870u_probe(struct pci_dev
base_io &= 0xfffffff8;
if ((ent->device == ATP880_DEVID1)||(ent->device == ATP880_DEVID2)) {
- error = pci_read_config_byte(pdev, PCI_CLASS_REVISION, &atpdev->chip_ver);
+ atpdev->chip_ver = pdev->revision;
pci_write_config_byte(pdev, PCI_LATENCY_TIMER, 0x80);//JCC082803
host_id = inb(base_io + 0x39);
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH resend] atp870u: use pci_dev->revision
2011-02-11 19:49 Sergei Shtylyov
@ 2011-03-24 19:51 ` Sergei Shtylyov
0 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2011-03-24 19:51 UTC (permalink / raw)
To: linux-scsi; +Cc: James.Bottomley
Hello.
On Friday 11 February 2011 10:49:34 pm Sergei Shtylyov wrote:
> This driver uses PCI_CLASS_REVISION instead of PCI_REVISION_ID, so it wasn't
> converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65 (PCI: Change all
> drivers to use pci_device->revision).
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> ---
> Resending with a proper tear line...
> drivers/scsi/atp870u.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-2.6/drivers/scsi/atp870u.c
> ===================================================================
> --- linux-2.6.orig/drivers/scsi/atp870u.c
> +++ linux-2.6/drivers/scsi/atp870u.c
> @@ -2583,7 +2583,7 @@ static int atp870u_probe(struct pci_dev
> * this than via the PCI device table
> */
> if (ent->device == PCI_DEVICE_ID_ARTOP_AEC7610) {
> - error = pci_read_config_byte(pdev, PCI_CLASS_REVISION, &atpdev->chip_ver);
> + atpdev->chip_ver = pdev->revision;
> if (atpdev->chip_ver < 2)
> goto err_eio;
> }
> @@ -2602,7 +2602,7 @@ static int atp870u_probe(struct pci_dev
> base_io &= 0xfffffff8;
>
> if ((ent->device == ATP880_DEVID1)||(ent->device == ATP880_DEVID2)) {
> - error = pci_read_config_byte(pdev, PCI_CLASS_REVISION, &atpdev->chip_ver);
> + atpdev->chip_ver = pdev->revision;
> pci_write_config_byte(pdev, PCI_LATENCY_TIMER, 0x80);//JCC082803
>
> host_id = inb(base_io + 0x39);
Hm. Will this and 2 other analogous patches of mine be queued somewhere?
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-10-05 15:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-13 15:01 [PATCH resend] atp870u: use pci_dev->revision Sergei Shtylyov
2011-07-21 15:35 ` Sergei Shtylyov
2011-10-05 14:56 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2011-02-11 19:49 Sergei Shtylyov
2011-03-24 19:51 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox