From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: linux-scsi@vger.kernel.org
Cc: James.Bottomley@suse.de, ravi.anand@qlogic.com,
vikas.chaudhary@qlogic.com, iscsi-driver@qlogic.com,
akpm@linux-foundation.org
Subject: [PATCH v2 resend] qla4xxx: use pci_dev->revision
Date: Wed, 5 Oct 2011 19:01:54 +0400 [thread overview]
Message-ID: <201110051901.54549.sshtylyov@ru.mvista.com> (raw)
In-Reply-To: <201107211937.37741.sshtylyov@ru.mvista.com>
Commit f4f5df23bf72208d0c2f1d8be629839924c2f4c2 ([SCSI] qla4xxx: Added support
for ISP82XX) added code to read the PCI revision ID from the PCI configuration
register while it's already stored by PCI subsystem in the 'revision' field of
'struct pci_dev'...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
The patch is against the recent Linus' tree.
It wasn't merged in either 2.6.39, 3.0 or 3.1 time, hopefully it can be merged
to 3.2...
Andrew, the SCSI maintainer seems to ignore this patch, maybe you can queue it?
drivers/scsi/qla4xxx/ql4_os.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
Index: linux-2.6/drivers/scsi/qla4xxx/ql4_os.c
===================================================================
--- linux-2.6.orig/drivers/scsi/qla4xxx/ql4_os.c
+++ linux-2.6/drivers/scsi/qla4xxx/ql4_os.c
@@ -1430,7 +1430,6 @@ static void qla4xxx_free_adapter(struct
int qla4_8xxx_iospace_config(struct scsi_qla_host *ha)
{
int status = 0;
- uint8_t revision_id;
unsigned long mem_base, mem_len, db_base, db_len;
struct pci_dev *pdev = ha->pdev;
@@ -1442,10 +1441,9 @@ int qla4_8xxx_iospace_config(struct scsi
goto iospace_error_exit;
}
- pci_read_config_byte(pdev, PCI_REVISION_ID, &revision_id);
DEBUG2(printk(KERN_INFO "%s: revision-id=%d\n",
- __func__, revision_id));
- ha->revision_id = revision_id;
+ __func__, pdev->revision));
+ ha->revision_id = pdev->revision;
/* remap phys address */
mem_base = pci_resource_start(pdev, 0); /* 0 is for BAR 0 */
next prev parent reply other threads:[~2011-10-05 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 15:04 [PATCH v2 resend] qla4xxx: use pci_dev->revision Sergei Shtylyov
2011-07-21 15:37 ` Sergei Shtylyov
2011-10-05 15:01 ` Sergei Shtylyov [this message]
2011-10-05 18:13 ` Vikas Chaudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110051901.54549.sshtylyov@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=iscsi-driver@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ravi.anand@qlogic.com \
--cc=vikas.chaudhary@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox