* [PATCH v2 resend] qla4xxx: use pci_dev->revision
@ 2011-05-13 15:04 Sergei Shtylyov
2011-07-21 15:37 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2011-05-13 15:04 UTC (permalink / raw)
To: linux-scsi, James.Bottomley; +Cc: ravi.anand, vikas.chaudhary, iscsi-driver
Commit f4f5df23bf72208d0c2f1d8be629839924c2f4c2 ([SCSI] qla4xxx: Added support
for ISP82XX) added code to read the PCI revision ID from the PCI configuration
register while it's already stored by PCI subsystem in the 'revision' field of
'struct pci_dev'...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
The patch is against the recent Linus' tree.
It wasn't merged in 2.6.39 time, I hope it can be merged to 2.6.40...
drivers/scsi/qla4xxx/ql4_os.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
Index: linux-2.6/drivers/scsi/qla4xxx/ql4_os.c
===================================================================
--- linux-2.6.orig/drivers/scsi/qla4xxx/ql4_os.c
+++ linux-2.6/drivers/scsi/qla4xxx/ql4_os.c
@@ -1428,7 +1428,6 @@ static void qla4xxx_free_adapter(struct
int qla4_8xxx_iospace_config(struct scsi_qla_host *ha)
{
int status = 0;
- uint8_t revision_id;
unsigned long mem_base, mem_len, db_base, db_len;
struct pci_dev *pdev = ha->pdev;
@@ -1440,10 +1439,9 @@ int qla4_8xxx_iospace_config(struct scsi
goto iospace_error_exit;
}
- pci_read_config_byte(pdev, PCI_REVISION_ID, &revision_id);
DEBUG2(printk(KERN_INFO "%s: revision-id=%d\n",
- __func__, revision_id));
- ha->revision_id = revision_id;
+ __func__, pdev->revision));
+ ha->revision_id = pdev->revision;
/* remap phys address */
mem_base = pci_resource_start(pdev, 0); /* 0 is for BAR 0 */
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2 resend] qla4xxx: use pci_dev->revision
2011-05-13 15:04 [PATCH v2 resend] qla4xxx: use pci_dev->revision Sergei Shtylyov
@ 2011-07-21 15:37 ` Sergei Shtylyov
2011-10-05 15:01 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2011-07-21 15:37 UTC (permalink / raw)
To: linux-scsi, James.Bottomley; +Cc: ravi.anand, vikas.chaudhary, iscsi-driver
Commit f4f5df23bf72208d0c2f1d8be629839924c2f4c2 ([SCSI] qla4xxx: Added support
for ISP82XX) added code to read the PCI revision ID from the PCI configuration
register while it's already stored by PCI subsystem in the 'revision' field of
'struct pci_dev'...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
The patch is against the recent Linus' tree.
It wasn't merged in either 2.6.39 or 3.0 time, hopefully it can be merged to
3.1...
drivers/scsi/qla4xxx/ql4_os.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
Index: linux-2.6/drivers/scsi/qla4xxx/ql4_os.c
===================================================================
--- linux-2.6.orig/drivers/scsi/qla4xxx/ql4_os.c
+++ linux-2.6/drivers/scsi/qla4xxx/ql4_os.c
@@ -1428,7 +1428,6 @@ static void qla4xxx_free_adapter(struct
int qla4_8xxx_iospace_config(struct scsi_qla_host *ha)
{
int status = 0;
- uint8_t revision_id;
unsigned long mem_base, mem_len, db_base, db_len;
struct pci_dev *pdev = ha->pdev;
@@ -1440,10 +1439,9 @@ int qla4_8xxx_iospace_config(struct scsi
goto iospace_error_exit;
}
- pci_read_config_byte(pdev, PCI_REVISION_ID, &revision_id);
DEBUG2(printk(KERN_INFO "%s: revision-id=%d\n",
- __func__, revision_id));
- ha->revision_id = revision_id;
+ __func__, pdev->revision));
+ ha->revision_id = pdev->revision;
/* remap phys address */
mem_base = pci_resource_start(pdev, 0); /* 0 is for BAR 0 */
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2 resend] qla4xxx: use pci_dev->revision
2011-07-21 15:37 ` Sergei Shtylyov
@ 2011-10-05 15:01 ` Sergei Shtylyov
2011-10-05 18:13 ` Vikas Chaudhary
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2011-10-05 15:01 UTC (permalink / raw)
To: linux-scsi
Cc: James.Bottomley, ravi.anand, vikas.chaudhary, iscsi-driver, akpm
Commit f4f5df23bf72208d0c2f1d8be629839924c2f4c2 ([SCSI] qla4xxx: Added support
for ISP82XX) added code to read the PCI revision ID from the PCI configuration
register while it's already stored by PCI subsystem in the 'revision' field of
'struct pci_dev'...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
The patch is against the recent Linus' tree.
It wasn't merged in either 2.6.39, 3.0 or 3.1 time, hopefully it can be merged
to 3.2...
Andrew, the SCSI maintainer seems to ignore this patch, maybe you can queue it?
drivers/scsi/qla4xxx/ql4_os.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
Index: linux-2.6/drivers/scsi/qla4xxx/ql4_os.c
===================================================================
--- linux-2.6.orig/drivers/scsi/qla4xxx/ql4_os.c
+++ linux-2.6/drivers/scsi/qla4xxx/ql4_os.c
@@ -1430,7 +1430,6 @@ static void qla4xxx_free_adapter(struct
int qla4_8xxx_iospace_config(struct scsi_qla_host *ha)
{
int status = 0;
- uint8_t revision_id;
unsigned long mem_base, mem_len, db_base, db_len;
struct pci_dev *pdev = ha->pdev;
@@ -1442,10 +1441,9 @@ int qla4_8xxx_iospace_config(struct scsi
goto iospace_error_exit;
}
- pci_read_config_byte(pdev, PCI_REVISION_ID, &revision_id);
DEBUG2(printk(KERN_INFO "%s: revision-id=%d\n",
- __func__, revision_id));
- ha->revision_id = revision_id;
+ __func__, pdev->revision));
+ ha->revision_id = pdev->revision;
/* remap phys address */
mem_base = pci_resource_start(pdev, 0); /* 0 is for BAR 0 */
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 resend] qla4xxx: use pci_dev->revision
2011-10-05 15:01 ` Sergei Shtylyov
@ 2011-10-05 18:13 ` Vikas Chaudhary
0 siblings, 0 replies; 4+ messages in thread
From: Vikas Chaudhary @ 2011-10-05 18:13 UTC (permalink / raw)
To: Sergei Shtylyov, scsi
Cc: James.Bottomley@suse.de, Ravi Anand, Dept_iscsi_driver,
akpm@linux-foundation.org
On 05/10/11 8:01 AM, "Sergei Shtylyov" <sshtylyov@ru.mvista.com> wrote:
>Commit f4f5df23bf72208d0c2f1d8be629839924c2f4c2 ([SCSI] qla4xxx: Added
>support
>for ISP82XX) added code to read the PCI revision ID from the PCI
>configuration
>register while it's already stored by PCI subsystem in the 'revision'
>field of
>'struct pci_dev'...
>
>Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
>---
>The patch is against the recent Linus' tree.
>It wasn't merged in either 2.6.39, 3.0 or 3.1 time, hopefully it can be
>merged
>to 3.2...
>
>Andrew, the SCSI maintainer seems to ignore this patch, maybe you can
>queue it?
>
> drivers/scsi/qla4xxx/ql4_os.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>Index: linux-2.6/drivers/scsi/qla4xxx/ql4_os.c
>===================================================================
>--- linux-2.6.orig/drivers/scsi/qla4xxx/ql4_os.c
>+++ linux-2.6/drivers/scsi/qla4xxx/ql4_os.c
>@@ -1430,7 +1430,6 @@ static void qla4xxx_free_adapter(struct
> int qla4_8xxx_iospace_config(struct scsi_qla_host *ha)
> {
> int status = 0;
>- uint8_t revision_id;
> unsigned long mem_base, mem_len, db_base, db_len;
> struct pci_dev *pdev = ha->pdev;
>
>@@ -1442,10 +1441,9 @@ int qla4_8xxx_iospace_config(struct scsi
> goto iospace_error_exit;
> }
>
>- pci_read_config_byte(pdev, PCI_REVISION_ID, &revision_id);
> DEBUG2(printk(KERN_INFO "%s: revision-id=%d\n",
>- __func__, revision_id));
>- ha->revision_id = revision_id;
>+ __func__, pdev->revision));
>+ ha->revision_id = pdev->revision;
>
> /* remap phys address */
> mem_base = pci_resource_start(pdev, 0); /* 0 is for BAR 0 */
>
Acked-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-05 18:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-13 15:04 [PATCH v2 resend] qla4xxx: use pci_dev->revision Sergei Shtylyov
2011-07-21 15:37 ` Sergei Shtylyov
2011-10-05 15:01 ` Sergei Shtylyov
2011-10-05 18:13 ` Vikas Chaudhary
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox