From: Yi Zou <yi.zou@intel.com>
To: linux-scsi@vger.kernel.org
Cc: robert.w.love@intel.com, Vasu Dev <vasu.dev@intel.com>,
Yi Zou <yi.zou@intel.com>
Subject: [PATCH 2/4] libfc: fix checking FC_TYPE_BLS
Date: Fri, 28 Oct 2011 11:34:12 -0700 [thread overview]
Message-ID: <20111028183412.15165.1173.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20111028183305.15165.96974.stgit@localhost6.localdomain6>
From: Vasu Dev <vasu.dev@intel.com>
Its checked after skb freed, so instead have fh_type
cached and then check FC_TYPE_BLS against cached
fh_type value.
This wrong check was causing double exch locking as
reported by Bhanu at
https://lists.open-fcoe.org/pipermail/devel/2011-October/011793.html
Signed-off-by: Vasu Dev <vasu.dev@intel.com>
Tested-by: Bhanu Prakash Gollapudi <bprakash@broadcom.com>
Signed-off-by: Yi Zou <yi.zou@intel.com>
---
drivers/scsi/libfc/fc_exch.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c
index 7c055fd..81235f3 100644
--- a/drivers/scsi/libfc/fc_exch.c
+++ b/drivers/scsi/libfc/fc_exch.c
@@ -469,6 +469,7 @@ static int fc_seq_send(struct fc_lport *lport, struct fc_seq *sp,
struct fc_frame_header *fh = fc_frame_header_get(fp);
int error;
u32 f_ctl;
+ u8 fh_type = fh->fh_type;
ep = fc_seq_exch(sp);
WARN_ON((ep->esb_stat & ESB_ST_SEQ_INIT) != ESB_ST_SEQ_INIT);
@@ -493,7 +494,7 @@ static int fc_seq_send(struct fc_lport *lport, struct fc_seq *sp,
*/
error = lport->tt.frame_send(lport, fp);
- if (fh->fh_type == FC_TYPE_BLS)
+ if (fh_type == FC_TYPE_BLS)
return error;
/*
next prev parent reply other threads:[~2011-10-28 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 18:34 [PATCH 0/4] Open-FCoE.org libfc and fcoe updates for scsi-misc Yi Zou
2011-10-28 18:34 ` [PATCH 1/4] drivers/firmware/edd: Treat "XPRS" host bus type the same as "PCI" Yi Zou
2011-10-28 18:34 ` Yi Zou [this message]
2011-10-28 18:34 ` [PATCH 3/4] libfc: avoid exchanges collision during lport reset Yi Zou
2011-10-28 18:34 ` [PATCH 4/4] libfc: improve flogi retries to avoid lport stuck Yi Zou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028183412.15165.1173.stgit@localhost6.localdomain6 \
--to=yi.zou@intel.com \
--cc=linux-scsi@vger.kernel.org \
--cc=robert.w.love@intel.com \
--cc=vasu.dev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox