From: Dan Carpenter <dan.carpenter@oracle.com>
To: nagalakshmi.nandigama@lsi.com
Cc: linux-scsi@vger.kernel.org
Subject: re: [SCSI] mpt2sas: New feature - Fast Load Support
Date: Thu, 3 Nov 2011 15:20:21 +0300 [thread overview]
Message-ID: <20111103122021.GA25772@elgon.mountain> (raw)
Hello nagalakshmi.nandigama@lsi.com,
This is a semi-automatic email about new static checker warnings.
The patch 921cd8024b90: "[SCSI] mpt2sas: New feature - Fast Load
Support" from Oct 19, 2011, leads to the following Smatch complaint:
drivers/scsi/mpt2sas/mpt2sas_base.c +3506 mpt2sas_port_enable_done()
error: we previously assumed 'mpi_reply' could be null (see line 3499)
drivers/scsi/mpt2sas/mpt2sas_base.c
3498 ioc->port_enable_cmds.status |= MPT2_CMD_COMPLETE;
3499 if (mpi_reply) {
^^^^^^^^^
check.
3500 ioc->port_enable_cmds.status |= MPT2_CMD_REPLY_VALID;
3501 memcpy(ioc->port_enable_cmds.reply, mpi_reply,
3502 mpi_reply->MsgLength*4);
3503 }
3504 ioc->port_enable_cmds.status &= ~MPT2_CMD_PENDING;
3505
3506 ioc_status = le16_to_cpu(mpi_reply->IOCStatus) & MPI2_IOCSTATUS_MASK;
^^^^^^^^^^^
dereference.
3507
3508 if (ioc_status != MPI2_IOCSTATUS_SUCCESS)
regards,
dan carpenter
next reply other threads:[~2011-11-03 12:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 12:20 Dan Carpenter [this message]
2011-11-04 11:50 ` [SCSI] mpt2sas: New feature - Fast Load Support Nandigama, Nagalakshmi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111103122021.GA25772@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nagalakshmi.nandigama@lsi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox