* re: [SCSI] mpt2sas: New feature - Fast Load Support
@ 2011-11-03 12:20 Dan Carpenter
2011-11-04 11:50 ` Nandigama, Nagalakshmi
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-11-03 12:20 UTC (permalink / raw)
To: nagalakshmi.nandigama; +Cc: linux-scsi
Hello nagalakshmi.nandigama@lsi.com,
This is a semi-automatic email about new static checker warnings.
The patch 921cd8024b90: "[SCSI] mpt2sas: New feature - Fast Load
Support" from Oct 19, 2011, leads to the following Smatch complaint:
drivers/scsi/mpt2sas/mpt2sas_base.c +3506 mpt2sas_port_enable_done()
error: we previously assumed 'mpi_reply' could be null (see line 3499)
drivers/scsi/mpt2sas/mpt2sas_base.c
3498 ioc->port_enable_cmds.status |= MPT2_CMD_COMPLETE;
3499 if (mpi_reply) {
^^^^^^^^^
check.
3500 ioc->port_enable_cmds.status |= MPT2_CMD_REPLY_VALID;
3501 memcpy(ioc->port_enable_cmds.reply, mpi_reply,
3502 mpi_reply->MsgLength*4);
3503 }
3504 ioc->port_enable_cmds.status &= ~MPT2_CMD_PENDING;
3505
3506 ioc_status = le16_to_cpu(mpi_reply->IOCStatus) & MPI2_IOCSTATUS_MASK;
^^^^^^^^^^^
dereference.
3507
3508 if (ioc_status != MPI2_IOCSTATUS_SUCCESS)
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [SCSI] mpt2sas: New feature - Fast Load Support
2011-11-03 12:20 [SCSI] mpt2sas: New feature - Fast Load Support Dan Carpenter
@ 2011-11-04 11:50 ` Nandigama, Nagalakshmi
0 siblings, 0 replies; 2+ messages in thread
From: Nandigama, Nagalakshmi @ 2011-11-04 11:50 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-scsi@vger.kernel.org
Thank you for the feedback. Will post a fix.
Regards,
Nagalakshmi
-----Original Message-----
From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
Sent: Thursday, November 03, 2011 5:50 PM
To: Nandigama, Nagalakshmi
Cc: linux-scsi@vger.kernel.org
Subject: re: [SCSI] mpt2sas: New feature - Fast Load Support
Hello nagalakshmi.nandigama@lsi.com,
This is a semi-automatic email about new static checker warnings.
The patch 921cd8024b90: "[SCSI] mpt2sas: New feature - Fast Load
Support" from Oct 19, 2011, leads to the following Smatch complaint:
drivers/scsi/mpt2sas/mpt2sas_base.c +3506 mpt2sas_port_enable_done()
error: we previously assumed 'mpi_reply' could be null (see line 3499)
drivers/scsi/mpt2sas/mpt2sas_base.c
3498 ioc->port_enable_cmds.status |= MPT2_CMD_COMPLETE;
3499 if (mpi_reply) {
^^^^^^^^^
check.
3500 ioc->port_enable_cmds.status |= MPT2_CMD_REPLY_VALID;
3501 memcpy(ioc->port_enable_cmds.reply, mpi_reply,
3502 mpi_reply->MsgLength*4);
3503 }
3504 ioc->port_enable_cmds.status &= ~MPT2_CMD_PENDING;
3505
3506 ioc_status = le16_to_cpu(mpi_reply->IOCStatus) & MPI2_IOCSTATUS_MASK;
^^^^^^^^^^^
dereference.
3507
3508 if (ioc_status != MPI2_IOCSTATUS_SUCCESS)
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-04 11:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-03 12:20 [SCSI] mpt2sas: New feature - Fast Load Support Dan Carpenter
2011-11-04 11:50 ` Nandigama, Nagalakshmi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox