From: Anton Blanchard <anton@samba.org>
To: kashyap.desai@lsi.com
Cc: eric.moore@lsi.com, JBottomley@parallels.com, linux-scsi@vger.kernel.org
Subject: Re: [SCSI] mpt2sas: _scsih_smart_predicted_fault uses GFP_KERNEL in interrupt context
Date: Mon, 7 Nov 2011 22:05:21 +1100 [thread overview]
Message-ID: <20111107220521.03e22b45@kryten> (raw)
In-Reply-To: <20110731192909.16bb341e@kryten>
Hi Kashyap,
On Sun, 31 Jul 2011 19:29:09 +1000
Anton Blanchard <anton@samba.org> wrote:
>
> _scsih_smart_predicted_fault is called in an interrupt and therefore
> must allocate memory using GFP_ATOMIC.
Just noticed this hasn't made it upstream, any chance you could review
it for merging?
Anton
--
_scsih_smart_predicted_fault is called in an interrupt and therefore
must allocate memory using GFP_ATOMIC.
Signed-off-by: Anton Blanchard <anton@samba.org>
Cc: <stable@kernel.org>
---
Index: linux-work/drivers/scsi/mpt2sas/mpt2sas_scsih.c
===================================================================
--- linux-work.orig/drivers/scsi/mpt2sas/mpt2sas_scsih.c 2011-11-07 22:03:33.728865287 +1100
+++ linux-work/drivers/scsi/mpt2sas/mpt2sas_scsih.c 2011-11-07 22:03:39.724972491 +1100
@@ -4330,7 +4330,7 @@ _scsih_smart_predicted_fault(struct MPT2
/* insert into event log */
sz = offsetof(Mpi2EventNotificationReply_t, EventData) +
sizeof(Mpi2EventDataSasDeviceStatusChange_t);
- event_reply = kzalloc(sz, GFP_KERNEL);
+ event_reply = kzalloc(sz, GFP_ATOMIC);
if (!event_reply) {
printk(MPT2SAS_ERR_FMT "failure at %s:%d/%s()!\n",
ioc->name, __FILE__, __LINE__, __func__);
next prev parent reply other threads:[~2011-11-07 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-31 9:29 [SCSI] mpt2sas: _scsih_smart_predicted_fault uses GFP_KERNEL in interrupt context Anton Blanchard
2011-11-07 11:05 ` Anton Blanchard [this message]
2011-11-10 4:17 ` Nandigama, Nagalakshmi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111107220521.03e22b45@kryten \
--to=anton@samba.org \
--cc=JBottomley@parallels.com \
--cc=eric.moore@lsi.com \
--cc=kashyap.desai@lsi.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox