From: Tejun Heo <tj@kernel.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Lin Ming <ming.m.lin@intel.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org,
Jeff Garzik <jgarzik@pobox.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
James Bottomley <JBottomley@parallels.com>,
Huang Ying <ying.huang@intel.com>,
Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH v2 4/4] ata: add ata port runtime PM callbacks
Date: Thu, 10 Nov 2011 07:45:50 -0800 [thread overview]
Message-ID: <20111110154550.GF27258@google.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1111101036160.2338-100000@iolanthe.rowland.org>
On Thu, Nov 10, 2011 at 10:40:21AM -0500, Alan Stern wrote:
> Are you really sure you want to keep this flag set throughout the
> lifetime of the port?
>
> What happens if a command fails, then the port suspends, and then the
> error handler is invoked to take care of the failed command?
Runtime PM doesn't happen if the device is in use in any way, so
there's no request flying in from upper layers. While the port is
suspended, qc's which which requested EH are short-circuited. AFAICS,
nothing is really wrong.
Thanks.
--
tejun
next prev parent reply other threads:[~2011-11-10 15:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 6:22 [PATCH v2 0/4] ata port runtime power management support Lin Ming
2011-11-10 6:22 ` [PATCH v2 1/4] ata: make ata port as parent device of scsi host Lin Ming
2011-11-10 6:22 ` [PATCH v2 2/4] scsi: add flag to skip the runtime PM calls on host in EH Lin Ming
2011-11-10 6:22 ` [PATCH v2 3/4] ata: add ata port system PM callbacks Lin Ming
2011-11-10 6:22 ` [PATCH v2 4/4] ata: add ata port runtime " Lin Ming
2011-11-10 15:40 ` Alan Stern
2011-11-10 15:45 ` Tejun Heo [this message]
[not found] ` <CAF1ivSZ3rnb90u6LHXfWCBW-6mtfmWYjj1xXfABmm=uNVbomRw@mail.gmail.com>
2011-11-14 5:14 ` Lin Ming
2011-11-14 15:31 ` Alan Stern
2011-11-15 8:51 ` Lin Ming
2011-11-15 14:54 ` Tejun Heo
2011-11-15 16:08 ` Alan Stern
2011-11-16 13:14 ` Lin Ming
2011-11-16 15:42 ` Alan Stern
2011-11-10 15:30 ` [PATCH v2 0/4] ata port runtime power management support Tejun Heo
2011-11-10 15:31 ` Tejun Heo
2011-11-11 2:25 ` Lin Ming
2011-11-10 16:02 ` Kay Sievers
2011-11-11 2:33 ` Lin Ming
2011-11-10 15:30 ` Alan Stern
2011-11-10 15:37 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111110154550.GF27258@google.com \
--to=tj@kernel.org \
--cc=JBottomley@parallels.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=rjw@sisk.pl \
--cc=rui.zhang@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).