linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] aacraid: controller hangs if kernel uses non-default ASPM policy
@ 2011-11-11  9:42 Vasily Averin
  2011-11-11 12:36 ` Achim Leubner
  2011-11-11 14:12 ` Matthew Garrett
  0 siblings, 2 replies; 3+ messages in thread
From: Vasily Averin @ 2011-11-11  9:42 UTC (permalink / raw)
  To: linux-scsi, Adaptec OEM Raid Solutions
  Cc: Matthew Garrett, James Bottomley, Mark Salyzyn

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

Patch from RHEL6 kernel
- [scsi] aacraid: Disable ASPM by default (Matthew Garrett) [599735]
aacraid controller hangs if kernel uses non-default ASPM policy

Signed-off-by:	Vasily Averin <vvs@sw.ru>
CC: Matthew Garrett <mjg@redhat.com>

[-- Attachment #2: diff-v31-aacraid-aspm-disable-20111110 --]
[-- Type: text/plain, Size: 656 bytes --]

diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 3382475..c7b6fed 100644
--- a/drivers/scsi/aacraid/linit.c
+++ b/drivers/scsi/aacraid/linit.c
@@ -38,6 +38,7 @@
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/pci.h>
+#include <linux/pci-aspm.h>
 #include <linux/slab.h>
 #include <linux/mutex.h>
 #include <linux/spinlock.h>
@@ -1108,6 +1109,9 @@ static int __devinit aac_probe_one(struct pci_dev *pdev,
 		unique_id++;
 	}
 
+	pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S | PCIE_LINK_STATE_L1 |
+			       PCIE_LINK_STATE_CLKPM);
+
 	error = pci_enable_device(pdev);
 	if (error)
 		goto out;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [patch] aacraid: controller hangs if kernel uses non-default ASPM policy
  2011-11-11  9:42 [patch] aacraid: controller hangs if kernel uses non-default ASPM policy Vasily Averin
@ 2011-11-11 12:36 ` Achim Leubner
  2011-11-11 14:12 ` Matthew Garrett
  1 sibling, 0 replies; 3+ messages in thread
From: Achim Leubner @ 2011-11-11 12:36 UTC (permalink / raw)
  To: Vasily Averin, linux-scsi; +Cc: Matthew Garrett, James Bottomley, Mark Salyzyn

Acked-by: Achim Leubner <Achim_Leubner@pmc-sierra.com>


-----Original Message-----
From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of Vasily Averin
Sent: Freitag, 11. November 2011 10:42
To: linux-scsi@vger.kernel.org; Adaptec OEM Raid Solutions
Cc: Matthew Garrett; James Bottomley; Mark Salyzyn
Subject: [patch] aacraid: controller hangs if kernel uses non-default ASPM policy

Patch from RHEL6 kernel
- [scsi] aacraid: Disable ASPM by default (Matthew Garrett) [599735]
aacraid controller hangs if kernel uses non-default ASPM policy

Signed-off-by:	Vasily Averin <vvs@sw.ru>
CC: Matthew Garrett <mjg@redhat.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] aacraid: controller hangs if kernel uses non-default ASPM policy
  2011-11-11  9:42 [patch] aacraid: controller hangs if kernel uses non-default ASPM policy Vasily Averin
  2011-11-11 12:36 ` Achim Leubner
@ 2011-11-11 14:12 ` Matthew Garrett
  1 sibling, 0 replies; 3+ messages in thread
From: Matthew Garrett @ 2011-11-11 14:12 UTC (permalink / raw)
  To: Vasily Averin
  Cc: linux-scsi, Adaptec OEM Raid Solutions, James Bottomley,
	Mark Salyzyn

On Fri, Nov 11, 2011 at 01:42:16PM +0400, Vasily Averin wrote:
> Patch from RHEL6 kernel
> - [scsi] aacraid: Disable ASPM by default (Matthew Garrett) [599735]
> aacraid controller hangs if kernel uses non-default ASPM policy
> 
> Signed-off-by:	Vasily Averin <vvs@sw.ru>
> CC: Matthew Garrett <mjg@redhat.com>

Checking the Windows drivers indicates that they disable ASPM under all 
circumstances, so:

Acked-by: Matthew Garrett <mjg@redhat.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-11-11 14:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-11  9:42 [patch] aacraid: controller hangs if kernel uses non-default ASPM policy Vasily Averin
2011-11-11 12:36 ` Achim Leubner
2011-11-11 14:12 ` Matthew Garrett

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).