From: Josh Boyer <jwboyer@redhat.com>
To: "James E.J. Bottomley" <JBottomley@parallels.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] [SCSI] sd: Lower printk level for drive cache information
Date: Mon, 28 Nov 2011 11:31:55 -0500 [thread overview]
Message-ID: <20111128163053.GA24618@zod.bos.redhat.com> (raw)
Numerous devices don't present cache data, particularly USB sticks. The
devices operate correctly despite this, so lower the printk severity to
KERN_NOTICE.
Signed-off-by: Josh Boyer <jwboyer@redhat.com>
---
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index fa3a591..7cf9ec5 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2119,7 +2119,7 @@ sd_read_cache_type(struct scsi_disk *sdkp, unsigned char *buffer)
}
if (modepage == 0x3F) {
- sd_printk(KERN_ERR, sdkp, "No Caching mode page "
+ sd_printk(KERN_NOTICE, sdkp, "No Caching mode page "
"present\n");
goto defaults;
} else if ((buffer[offset] & 0x3f) != modepage) {
@@ -2164,7 +2164,7 @@ bad_sense:
sd_printk(KERN_ERR, sdkp, "Asking for cache data failed\n");
defaults:
- sd_printk(KERN_ERR, sdkp, "Assuming drive cache: write through\n");
+ sd_printk(KERN_NOTICE, sdkp, "Assuming drive cache: write through\n");
sdkp->WCE = 0;
sdkp->RCD = 0;
sdkp->DPOFUA = 0;
next reply other threads:[~2011-11-28 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 16:31 Josh Boyer [this message]
2011-11-29 4:44 ` [PATCH] [SCSI] sd: Lower printk level for drive cache information Christoph Hellwig
2011-11-29 15:03 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111128163053.GA24618@zod.bos.redhat.com \
--to=jwboyer@redhat.com \
--cc=JBottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox