public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Josh Boyer <jwboyer@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [SCSI] sd: Lower printk level for drive cache information
Date: Tue, 29 Nov 2011 10:03:16 -0500	[thread overview]
Message-ID: <20111129150112.GA2453@zod.bos.redhat.com> (raw)
In-Reply-To: <20111129044442.GA19616@infradead.org>

On Mon, Nov 28, 2011 at 11:44:42PM -0500, Christoph Hellwig wrote:
> On Mon, Nov 28, 2011 at 11:31:55AM -0500, Josh Boyer wrote:
> > Numerous devices don't present cache data, particularly USB sticks.  The
> > devices operate correctly despite this, so lower the printk severity to
> > KERN_NOTICE.
> 
> Do they?  The last reports on the list were for devices that didn't
> present it but actually needed cache flushes despite not having the
> cache mode page.

We've seen a number of reports for liveusb images that spit out those
printks, but seem to otherwise work fine.

Even if the devices need cache flushes, what is a typical user supposed
to do about that?  I'm not particularly tied to this patch, but there is
nothing a normal user can do with the information spit out by these
printks, so making it KERN_ERR seems excessive.

josh
> 

      reply	other threads:[~2011-11-29 15:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-28 16:31 [PATCH] [SCSI] sd: Lower printk level for drive cache information Josh Boyer
2011-11-29  4:44 ` Christoph Hellwig
2011-11-29 15:03   ` Josh Boyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111129150112.GA2453@zod.bos.redhat.com \
    --to=jwboyer@redhat.com \
    --cc=JBottomley@parallels.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox