From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [RESEND][PATCH 4/4] scsi_dh: code cleanup and remove the references to scsi_dev_info Date: Wed, 30 Nov 2011 17:52:11 -0500 Message-ID: <20111130225211.GA18168@redhat.com> References: <47D23AD8469A2B448F33C24BD7A39BD9105DBE66@RTPMVEXC1-PRD.hq.netapp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com ([209.132.183.28]:3669 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751665Ab1K3Wwf (ORCPT ); Wed, 30 Nov 2011 17:52:35 -0500 Content-Disposition: inline In-Reply-To: <47D23AD8469A2B448F33C24BD7A39BD9105DBE66@RTPMVEXC1-PRD.hq.netapp.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Moger, Babu" Cc: Linux SCSI Mailing list , device-mapper development , hare@suse.de On Thu, Nov 03 2011 at 11:52am -0400, Moger, Babu wrote: > All the handlers have implemented the match function(look at patch 1, 2, 3). > We don't need to use scsi_dev_info any more for matching purposes. > Cleaning up the scsi_dh code. > > FYI.. > Match function was originally implemented by this > > http://www.spinics.net/lists/linux-scsi/msg54284.html > or > http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=6c3633d08acf514e2e89aa95d2346ce9d64d719a > > Signed-off-by: Babu Moger Looks good, effectively reverts commit 940d7faa481 But SCSI_DEVINFO_DH can be removed too: diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h index a6ebf4c..1fbf7c7 100644 --- a/drivers/scsi/scsi_priv.h +++ b/drivers/scsi/scsi_priv.h @@ -44,7 +44,6 @@ static inline void scsi_log_completion(struct scsi_cmnd *cmd, int disposition) enum { SCSI_DEVINFO_GLOBAL = 0, SCSI_DEVINFO_SPI, - SCSI_DEVINFO_DH, }; extern int scsi_get_device_flags(struct scsi_device *sdev,