From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Williams Subject: [PATCH 21/24] libsas: Remove redundant phy state notification calls. Date: Fri, 16 Dec 2011 18:34:57 -0800 Message-ID: <20111217023457.15036.62654.stgit@localhost6.localdomain6> References: <20111217022912.15036.85808.stgit@localhost6.localdomain6> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111217022912.15036.85808.stgit@localhost6.localdomain6> Sender: linux-ide-owner@vger.kernel.org To: linux-scsi@vger.kernel.org Cc: Xiangliang Yu , linux-ide@vger.kernel.org, Jeff Skirvin , Luben Tuikov , Jack Wang List-Id: linux-scsi@vger.kernel.org From: Jeff Skirvin In the case of an explicit sas_phy_enable call to disable a phy, the LLDD provides the calls to sas_phy_disconnected and the PHYE_LOSS_OF_SIGNAL event. NOTE: This assumes that the lldd(s) generate the notification, which appears to be the case, but only verfied on isci. Cc: Jack Wang Cc: Xiangliang Yu Cc: Luben Tuikov Signed-off-by: Jeff Skirvin Signed-off-by: Dan Williams --- drivers/scsi/libsas/sas_init.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/libsas/sas_init.c b/drivers/scsi/libsas/sas_init.c index e461b98..38fc521 100644 --- a/drivers/scsi/libsas/sas_init.c +++ b/drivers/scsi/libsas/sas_init.c @@ -264,11 +264,8 @@ static int sas_phy_enable(struct sas_phy *phy, int enable) if (enable) ret = transport_sas_phy_reset(phy, 0); - else { - sas_phy_disconnected(asd_phy); - sas_ha->notify_phy_event(asd_phy, PHYE_LOSS_OF_SIGNAL); + else ret = i->dft->lldd_control_phy(asd_phy, cmd, NULL); - } } else { struct sas_rphy *rphy = dev_to_rphy(phy->dev.parent); struct domain_device *ddev = sas_find_dev_by_rphy(rphy);