* [PATCH] SCSI: Change size of factor from u64 to unsigned int.
@ 2011-12-22 17:18 Ralf Baechle
0 siblings, 0 replies; only message in thread
From: Ralf Baechle @ 2011-12-22 17:18 UTC (permalink / raw)
To: James E.J. Bottomley; +Cc: linux-scsi, linux-mips, linux-kernel
Struct scsi_device.sector_size is unsigned int, so the value of factor
can have at most 23 significant bits.
Adding a type check to do_div() caught these two do_div as the only
invocations in the kernel passing a non-32-bit divisor.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-scsi@vger.kernel.org
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
---
drivers/scsi/sd.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index fa3a591..42a1ff6 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1335,8 +1335,7 @@ static unsigned int sd_completed_bytes(struct scsi_cmnd *scmd)
start_lba <<= 1;
end_lba <<= 1;
} else {
- /* be careful ... don't want any overflows */
- u64 factor = scmd->device->sector_size / 512;
+ unsigned int factor = scmd->device->sector_size / 512;
do_div(start_lba, factor);
do_div(end_lba, factor);
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-12-22 17:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-22 17:18 [PATCH] SCSI: Change size of factor from u64 to unsigned int Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).