* [patch 1/6] scsi: fix a header to include linux/types.h
@ 2011-05-23 22:29 akpm
0 siblings, 0 replies; 5+ messages in thread
From: akpm @ 2011-05-23 22:29 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, akpm, virtuoso
From: Alexander Shishkin <virtuoso@slind.org>
For headers that get exported to userland and make use of u32 style
type names, it is advised to include linux/types.h.
This fixes a headers_check warning.
Signed-off-by: Alexander Shishkin <virtuoso@slind.org>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/scsi/scsi_netlink.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN include/scsi/scsi_netlink.h~scsi-fix-a-header-to-include-linux-typesh include/scsi/scsi_netlink.h
--- a/include/scsi/scsi_netlink.h~scsi-fix-a-header-to-include-linux-typesh
+++ a/include/scsi/scsi_netlink.h
@@ -23,7 +23,7 @@
#define SCSI_NETLINK_H
#include <linux/netlink.h>
-
+#include <linux/types.h>
/*
* This file intended to be included by both kernel and user space
_
^ permalink raw reply [flat|nested] 5+ messages in thread
* [patch 1/6] scsi: fix a header to include linux/types.h
@ 2011-11-15 22:58 akpm
0 siblings, 0 replies; 5+ messages in thread
From: akpm @ 2011-11-15 22:58 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, akpm, virtuoso
From: Alexander Shishkin <virtuoso@slind.org>
Subject: scsi: fix a header to include linux/types.h
For headers that get exported to userland and make use of u32 style
type names, it is advised to include linux/types.h.
This fixes a headers_check warning.
Signed-off-by: Alexander Shishkin <virtuoso@slind.org>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/scsi/scsi_netlink.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN include/scsi/scsi_netlink.h~scsi-fix-a-header-to-include-linux-typesh include/scsi/scsi_netlink.h
--- a/include/scsi/scsi_netlink.h~scsi-fix-a-header-to-include-linux-typesh
+++ a/include/scsi/scsi_netlink.h
@@ -23,7 +23,7 @@
#define SCSI_NETLINK_H
#include <linux/netlink.h>
-
+#include <linux/types.h>
/*
* This file intended to be included by both kernel and user space
_
^ permalink raw reply [flat|nested] 5+ messages in thread
* [patch 1/6] scsi: fix a header to include linux/types.h
@ 2012-01-10 23:42 akpm
2012-01-11 0:02 ` James Bottomley
0 siblings, 1 reply; 5+ messages in thread
From: akpm @ 2012-01-10 23:42 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, akpm, virtuoso
From: Alexander Shishkin <virtuoso@slind.org>
Subject: scsi: fix a header to include linux/types.h
For headers that get exported to userland and make use of u32 style
type names, it is advised to include linux/types.h.
This fixes a headers_check warning.
Signed-off-by: Alexander Shishkin <virtuoso@slind.org>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/scsi/scsi_netlink.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN include/scsi/scsi_netlink.h~scsi-fix-a-header-to-include-linux-typesh include/scsi/scsi_netlink.h
--- a/include/scsi/scsi_netlink.h~scsi-fix-a-header-to-include-linux-typesh
+++ a/include/scsi/scsi_netlink.h
@@ -23,7 +23,7 @@
#define SCSI_NETLINK_H
#include <linux/netlink.h>
-
+#include <linux/types.h>
/*
* This file intended to be included by both kernel and user space
_
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch 1/6] scsi: fix a header to include linux/types.h
2012-01-10 23:42 [patch 1/6] scsi: fix a header to include linux/types.h akpm
@ 2012-01-11 0:02 ` James Bottomley
2012-01-11 0:08 ` Andrew Morton
0 siblings, 1 reply; 5+ messages in thread
From: James Bottomley @ 2012-01-11 0:02 UTC (permalink / raw)
To: akpm; +Cc: linux-scsi, virtuoso
On Tue, 2012-01-10 at 15:42 -0800, akpm@linux-foundation.org wrote:
> From: Alexander Shishkin <virtuoso@slind.org>
> Subject: scsi: fix a header to include linux/types.h
>
> For headers that get exported to userland and make use of u32 style
> type names, it is advised to include linux/types.h.
>
> This fixes a headers_check warning.
Well, this patch isn't correct as I've said several times (we really
need someone to take a serious look at all the problems with exporting
scsi.h to userspace). The warning was finally fixed by this patch
instead:
commit 7407e5bba2cc821950344fd1391d9ad1b7e0b397
Author: Tom Rini <tom_rini@mentor.com>
Date: Tue Apr 27 14:11:47 2010 -0700
[SCSI] Unexport scsi/scsi.h from headers_install
But if someone wants to step up and make scsi/scsi.h exportable, I'm
very open ...
James
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch 1/6] scsi: fix a header to include linux/types.h
2012-01-11 0:02 ` James Bottomley
@ 2012-01-11 0:08 ` Andrew Morton
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Morton @ 2012-01-11 0:08 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi, virtuoso
On Tue, 10 Jan 2012 19:02:48 -0500
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> On Tue, 2012-01-10 at 15:42 -0800, akpm@linux-foundation.org wrote:
> > From: Alexander Shishkin <virtuoso@slind.org>
> > Subject: scsi: fix a header to include linux/types.h
> >
> > For headers that get exported to userland and make use of u32 style
> > type names, it is advised to include linux/types.h.
> >
> > This fixes a headers_check warning.
>
> Well, this patch isn't correct as I've said several times
You didn't reply to Alexander's initial email, nor to my May and
November resends of this patch.
> The warning was finally fixed by this patch instead:
OK, thanks, I'll drop the patch.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-11 0:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-10 23:42 [patch 1/6] scsi: fix a header to include linux/types.h akpm
2012-01-11 0:02 ` James Bottomley
2012-01-11 0:08 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2011-11-15 22:58 akpm
2011-05-23 22:29 akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).