From: Andrew Morton <akpm@linux-foundation.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi@vger.kernel.org, sboyd@codeaurora.org,
dgilbert@interlog.com, dougg@torque.net
Subject: Re: [patch 4/6] drivers/scsi/sg.c: convert to kstrtoul_from_user()
Date: Tue, 10 Jan 2012 16:12:27 -0800 [thread overview]
Message-ID: <20120110161227.cc8449f2.akpm@linux-foundation.org> (raw)
In-Reply-To: <1326240524.3264.91.camel@dabdike.int.hansenpartnership.com>
On Tue, 10 Jan 2012 19:08:44 -0500
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> On Tue, 2012-01-10 at 15:42 -0800, akpm@linux-foundation.org wrote:
> > From: Stephen Boyd <sboyd@codeaurora.org>
> > Subject: drivers/scsi/sg.c: convert to kstrtoul_from_user()
> >
> > Instead of open coding this function use kstrtoul_from_user() directly.
>
> I really don't like these invent post facto functions and then try to
> insert them on the grounds the original users are now "open coded".
> However, if doug acks (or sends it as part of an update), I'll apply.
>
The main reason for adding helpers such as kstrtoul_from_user() is that
we have recognised that certain code patterns appear in multiple
places. So we add the helper and then clean up the code sites which
inspired that addition.
This is good! It's a part of our basic code maintenance.
next prev parent reply other threads:[~2012-01-11 0:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 23:42 [patch 4/6] drivers/scsi/sg.c: convert to kstrtoul_from_user() akpm
2012-01-11 0:08 ` James Bottomley
2012-01-11 0:12 ` Andrew Morton [this message]
2012-01-11 13:08 ` Douglas Gilbert
-- strict thread matches above, loose matches on Subject: below --
2011-11-15 22:58 akpm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110161227.cc8449f2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dgilbert@interlog.com \
--cc=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox