From: Dan Carpenter <dan.carpenter@oracle.com>
To: kgudipat@brocade.com
Cc: linux-scsi@vger.kernel.org
Subject: re: [SCSI] bfa: Implement LUN Masking feature using the SCSI Slave Callouts.
Date: Wed, 11 Jan 2012 12:32:34 +0300 [thread overview]
Message-ID: <20120111093234.GA30629@elgon.mountain> (raw)
Hello Krishna Gudipati,
This is a semi-automatic email about new static checker warnings.
The patch 5b7db7af522d: "[SCSI] bfa: Implement LUN Masking feature
using the SCSI Slave Callouts." from Dec 20, 2011, leads to the
following Smatch complaint:
drivers/scsi/bfa/bfad_im.c +962 bfad_im_slave_alloc()
warn: variable dereferenced before check 'rport' (see line 959)
drivers/scsi/bfa/bfad_im.c
957 struct fc_rport *rport = starget_to_rport(scsi_target(sdev));
958 struct bfad_itnim_data_s *itnim_data =
959 (struct bfad_itnim_data_s *) rport->dd_data;
^^^^^^^
New dereference.
960 struct bfa_s *bfa = itnim_data->itnim->bfa_itnim->bfa;
961
962 if (!rport || fc_remote_port_chkready(rport))
^^^^^
Old check.
963 return -ENXIO;
964
regards,
dan carpenter
next reply other threads:[~2012-01-11 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 9:32 Dan Carpenter [this message]
[not found] <20120627085800.GA3007@mwanda>
2012-06-27 9:05 ` [SCSI] bfa: Implement LUN Masking feature using the SCSI Slave Callouts Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111093234.GA30629@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kgudipat@brocade.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox