Re: [patch] target: handle empty string writes in sysfs

[Dan Carpenter <dan.carpenter@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

On Tue, Jan 24, 2012 at 11:55:45AM +0100, walter harms wrote:
> 
> 
> Am 24.01.2012 09:40, schrieb Dan Carpenter:
> > These are root only and we're not likely to hit the problem in practise,
> > but it makes a the static checkers happy.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > 
> > diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
> > index 0955bb8..9b86330 100644
> > --- a/drivers/target/target_core_configfs.c
> > +++ b/drivers/target/target_core_configfs.c
> > @@ -1707,6 +1707,8 @@ static ssize_t target_core_store_dev_alias(
> >  	se_dev->su_dev_flags |= SDF_USING_ALIAS;
> >  	read_bytes = snprintf(&se_dev->se_dev_alias[0], SE_DEV_ALIAS_LEN,
> >  			"%s", page);
> 
> Would it help to check page==NULL or *page==0 at start ?
> Now you have se_dev->su_dev_flags initialised.

It's a fair point.  Let me redo it.

regards,
dan carpenter


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]