From: Jan Kara <jack@suse.cz>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
James Bottomley <JBottomley@parallels.com>,
mmarek@suse.cz
Subject: Ioctl warning for a partition
Date: Thu, 26 Jan 2012 23:30:37 +0100 [thread overview]
Message-ID: <20120126223037.GE28368@quack.suse.cz> (raw)
Hello,
with your patches (commit 0bfc96cb in particular) to limit ioctl on
partitions we get warning:
dd: sending ioctl 80306d02 to a partition!
because dd checks whether given device is a tape (it's MTIOCGET ioctl).
It's easy enough to silence the warning the same way as
CDROM_GET_CAPABILITY since the ioctl is safe but it's not so simple for
32-bit userspace. MTIOCGET32 is defined only in fs/compat_ioctl.c so we
cannot easily add it to scsi_verify_blk_ioctl(). Any opinion how to cleanly
solve this? The only idea I had was to define compat structures and ioctl
numbers in a special header and use it both in fs/compat_ioctl.c and in
block/scsi_ioctl.c.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next reply other threads:[~2012-01-26 22:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 22:30 Jan Kara [this message]
2012-01-26 23:01 ` Ioctl warning for a partition Linus Torvalds
2012-01-26 23:56 ` Michael Tokarev
2012-01-27 19:28 ` Henrique de Moraes Holschuh
2012-01-27 19:37 ` Henrique de Moraes Holschuh
2012-01-28 10:22 ` Paolo Bonzini
2012-01-28 14:41 ` Henrique de Moraes Holschuh
2012-01-27 8:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120126223037.GE28368@quack.suse.cz \
--to=jack@suse.cz \
--cc=JBottomley@parallels.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=pbonzini@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox