From: Dan Williams <dan.j.williams@intel.com>
To: linux-scsi@vger.kernel.org
Cc: Andrzej Jakowski <andrzej.jakowski@intel.com>
Subject: [PATCH v1 5/5] isci: improvements in driver unloading routine
Date: Fri, 10 Feb 2012 01:18:54 -0800 [thread overview]
Message-ID: <20120210091854.26719.90584.stgit@dwillia2-linux.jf.intel.com> (raw)
In-Reply-To: <20120210091814.26719.75603.stgit@dwillia2-linux.jf.intel.com>
From: Andrzej Jakowski <andrzej.jakowski@intel.com>
This patch fixes scenario where driver removal should be possible
only when driver is in READY state. Also it removes redundant
invocation of routine disabling SCU interrupts - this method is
called somewhere else in driver deinitialization path.
Signed-off-by: Andrzej Jakowski <andrzej.jakowski@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
drivers/scsi/isci/init.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c
index c3fe39b..7c7de43 100644
--- a/drivers/scsi/isci/init.c
+++ b/drivers/scsi/isci/init.c
@@ -60,6 +60,7 @@
#include <linux/efi.h>
#include <asm/string.h>
#include <scsi/scsi_host.h>
+#include "host.h"
#include "isci.h"
#include "task.h"
#include "probe_roms.h"
@@ -553,9 +554,9 @@ static void __devexit isci_pci_remove(struct pci_dev *pdev)
int i;
for_each_isci_host(i, ihost, pdev) {
+ wait_for_start(ihost);
isci_unregister(ihost);
isci_host_deinit(ihost);
- sci_controller_disable_interrupts(ihost);
}
}
prev parent reply other threads:[~2012-02-10 9:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 9:18 [PATCH v1 0/5] isci updates for -next Dan Williams
2012-02-10 9:18 ` [PATCH v1 1/5] isci: T10 DIF support Dan Williams
2012-02-13 17:14 ` Martin K. Petersen
2012-02-10 9:18 ` [PATCH v1 2/5] isci: enable clock gating Dan Williams
2012-02-10 9:18 ` [PATCH v1 3/5] isci: debug, provide state-enum-to-string conversions Dan Williams
2012-02-19 15:17 ` James Bottomley
2012-02-10 9:18 ` [PATCH v1 4/5] isci: improve phy event warnings Dan Williams
2012-02-10 9:18 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210091854.26719.90584.stgit@dwillia2-linux.jf.intel.com \
--to=dan.j.williams@intel.com \
--cc=andrzej.jakowski@intel.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).