From: Robert Love <robert.w.love@intel.com>
To: linux-scsi@vger.kernel.org
Cc: Ross Brattain <ross.b.brattain@intel.com>
Subject: [PATCH 08/12] fcoe: Rename out_nomod label to out_putmod
Date: Fri, 10 Feb 2012 17:18:36 -0800 [thread overview]
Message-ID: <20120211011836.7668.98422.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20120211011754.7668.51489.stgit@localhost6.localdomain6>
The label implies that it should be called when
there is 'nomod.' I read that to mean that the
module reference 'get' failed. However, it's only
called when the module reference 'get' succeeded.
I think it makes more sense to name the label,
'out_putmod' since it should be called when we
need to 'put' the module reference taken in the
routine before returning.
Signed-off-by: Robert Love <robert.w.love@intel.com>
Tested-by: Ross Brattain <ross.b.brattain@intel.com>
---
drivers/scsi/fcoe/fcoe.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index 5e77f23..449df17 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -372,7 +372,7 @@ static struct fcoe_interface *fcoe_interface_create(struct net_device *netdev,
if (!fcoe) {
FCOE_NETDEV_DBG(netdev, "Could not allocate fcoe structure\n");
fcoe = ERR_PTR(-ENOMEM);
- goto out_nomod;
+ goto out_putmod;
}
dev_hold(netdev);
@@ -392,12 +392,12 @@ static struct fcoe_interface *fcoe_interface_create(struct net_device *netdev,
kfree(fcoe);
dev_put(netdev);
fcoe = ERR_PTR(err);
- goto out_nomod;
+ goto out_putmod;
}
goto out;
-out_nomod:
+out_putmod:
module_put(THIS_MODULE);
out:
return fcoe;
next prev parent reply other threads:[~2012-02-11 1:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-11 1:17 [PATCH 00/12] libfc, libfcoe and fcoe updates for scsi-misc Robert Love
2012-02-11 1:17 ` [PATCH 01/12] libfcoe: Don't KERN_ERR on netdev notification Robert Love
2012-02-11 1:18 ` [PATCH 02/12] scsi_transport_fc: Add FDMI host attributes Robert Love
2012-02-11 1:18 ` [PATCH 03/12] scsi_transport_fc: Getting FC Port Speed in sync with FC-GS Robert Love
2012-02-11 1:18 ` [PATCH 04/12] libfc: Make the libfc Common Transport(CT) code generic Robert Love
2012-02-11 1:18 ` [PATCH 05/12] libfc: Add support for FDMI Robert Love
2012-02-11 1:18 ` [PATCH 06/12] fcoe: Add support for FDMI in fcoe Robert Love
2012-02-11 1:18 ` [PATCH 07/12] fcoe: Allow exposing FDMI attributes via sysfs Robert Love
2012-02-11 1:18 ` Robert Love [this message]
2012-02-11 1:18 ` [PATCH 09/12] fcoe: Do not switch context in vport_delete callback Robert Love
2012-02-11 1:18 ` [PATCH 10/12] fcoe: Remove reference counting on 'stuct fcoe_interface' Robert Love
2012-02-11 1:18 ` [PATCH 11/12] libfc: Fix panic in fc_exch_recv Robert Love
2012-02-11 1:18 ` [PATCH 12/12] libfc: Handle discovery failure during ctlr link down Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120211011836.7668.98422.stgit@localhost6.localdomain6 \
--to=robert.w.love@intel.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ross.b.brattain@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).