Re: [PATCH 1/3] firewire-sbp2: Take into account Unit_Unique_ID

Stefan Richter
2012-02-11T13:06:05Z

On Feb 11 Chris Boot wrote:
> On 11/02/2012 11:12, Stefan Richter wrote:
> > On Feb 10 Chris Boot wrote:
> >> + if ((leaf[0]& 0xffff0000) != 0x00020000)
> >> + return -EINVAL;
> >
> > This could be relaxed to "if (leaf[0]< 0x00020000)", but the stricter
> > check is fine too.
>
> Well the standard does say the length must be exactly 2 rather than just
> defining it a leaf node that contains an EUI-64. But I did not realise
> various firmware gets things quite so wrong sometimes...

I expect firmware writers to get length == 2 right, but we need to
protect ourselves against very dumb mistakes or malicious input of course.

Whether the length field is 2 or not could be totally ignored by
firewire-sbp2 just like we ignore the block CRC, except that we need to
catch the corner case of a bogus Config ROM where the descriptor leaf
overlaps the 1 kB ROM size limit, or that it is placed right at the end of
the ROM but is shorter than 2 quadlets.

core-device.c::read_config_rom() already catches the cases of blocks
overlapping the end of the ROM but merely handles them by overwriting the
block length by 0. Higher-level code which reads a descriptor block or
directory block in the Config ROM cache is required to respect the length
field of the block. We could simplify this for upper layer code by
overwriting the pointer to the block instead of the header of the block,
like it is done already with pointers to blocks outside of the ROM.

Anyway; if the length of an alleged EUI-64 descriptor leaf is greater than
2, I agree that there is little reason to look at the rest of the
descriptor; it would likely contain garbage too.
--
Stefan Richter
-=====-===-- --=- -=-==