From: Christoph Hellwig <hch@infradead.org>
To: Roland Dreier <roland@kernel.org>
Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH] iscsi-target: Fix memory leak if iscsit_alloc_buffs() fails
Date: Sat, 25 Feb 2012 04:24:55 -0500 [thread overview]
Message-ID: <20120225092455.GA23775@infradead.org> (raw)
In-Reply-To: <1330046923-4034-1-git-send-email-roland@kernel.org>
On Thu, Feb 23, 2012 at 05:28:43PM -0800, Roland Dreier wrote:
> From: Roland Dreier <roland@purestorage.com>
>
> The function kzalloc()s sgl, but if page allocation fails, it never
> frees sgl on the page_alloc_failed path.
Can we fix this properly by killing the code? After the last round
of cleanups there is no reason why iscsi can't use the generic page
allocation code in transport_generic_get_mem().
next prev parent reply other threads:[~2012-02-25 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 1:28 [PATCH] iscsi-target: Fix memory leak if iscsit_alloc_buffs() fails Roland Dreier
2012-02-25 1:17 ` Nicholas A. Bellinger
2012-02-25 5:19 ` Roland Dreier
2012-02-25 21:28 ` Nicholas A. Bellinger
2012-02-25 9:24 ` Christoph Hellwig [this message]
2012-03-26 9:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120225092455.GA23775@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=roland@kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).