From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [resend] [patch] [SCSI] bfa: dereferencing freed memory in bfad_im_probe() Date: Wed, 29 Feb 2012 15:59:33 +0300 Message-ID: <20120229125933.GA23250@elgon.mountain> References: <20110729085306.GH3752@shale.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20110729085306.GH3752@shale.localdomain> Sender: linux-kernel-owner@vger.kernel.org To: Jing Huang Cc: "James E.J. Bottomley" , "open list:BROCADE BFA FC SC..." , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-scsi@vger.kernel.org If bfad_thread_workq(bfad) was not BFA_STATUS_OK then we freed "im" and then dereferenced it. I did a little clean up because it seemed nicer to return directly instead of doing a superfluous goto. I looked at other functions in this file and it seems like returning directly is standard. Signed-off-by: Dan Carpenter --- I sent this last July and asked about it again in November but I never heard back. It still applies fine with 2 lines of fuzz. diff --git a/drivers/scsi/bfa/bfad_im.c b/drivers/scsi/bfa/bfad_im.c index 0131238..7f7cca0 100644 --- a/drivers/scsi/bfa/bfad_im.c +++ b/drivers/scsi/bfa/bfad_im.c @@ -685,25 +685,21 @@ bfa_status_t bfad_im_probe(struct bfad_s *bfad) { struct bfad_im_s *im; - bfa_status_t rc = BFA_STATUS_OK; im = kzalloc(sizeof(struct bfad_im_s), GFP_KERNEL); - if (im == NULL) { - rc = BFA_STATUS_ENOMEM; - goto ext; - } + if (im == NULL) + return BFA_STATUS_ENOMEM; bfad->im = im; im->bfad = bfad; if (bfad_thread_workq(bfad) != BFA_STATUS_OK) { kfree(im); - rc = BFA_STATUS_FAILED; + return BFA_STATUS_FAILED; } INIT_WORK(&im->aen_im_notify_work, bfad_aen_im_notify_handler); -ext: - return rc; + return BFA_STATUS_OK; } void