From: Dan Carpenter <dan.carpenter@oracle.com>
To: santosh prasad nayak <santoshprasadnayak@gmail.com>
Cc: Jack Wang <jack_wang@usish.com>, linux-scsi@vger.kernel.org
Subject: Re: [SCSI] pm8001: Fix bogus interrupt state flag issue.
Date: Thu, 1 Mar 2012 17:37:58 +0300 [thread overview]
Message-ID: <20120301143757.GT1003@mwanda> (raw)
In-Reply-To: <CAOD=uF46HF3iLto3AhnTkjzSDebAkCYtTE-UJ26s00CwgwRPYA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
On Thu, Mar 01, 2012 at 07:54:57PM +0530, santosh prasad nayak wrote:
> The warnings are there since from the beginning.
> Even before my fix.
>
> There are two locks:
> 1. pm8001_ha->lock
> 2. t->task_state_lock
>
Yes. But IRQs are either enabled or disabled for the CPU. You
can't enable them twice.
In this case we enable them in the first call to unlock and the
second call doesn't do anything. So possibly the current behavior
is correct and we should change the second unlock or possibly the
current behavior is wrong and we should change the first unlock.
But actually the email was more of just a form letter. Perhaps Jack
knows what to do here...
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-01 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 14:22 [SCSI] pm8001: Fix bogus interrupt state flag issue Dan Carpenter
2012-03-01 14:24 ` santosh prasad nayak
2012-03-01 14:37 ` Dan Carpenter [this message]
2012-03-01 14:41 ` santosh prasad nayak
2012-03-02 1:06 ` Jack Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301143757.GT1003@mwanda \
--to=dan.carpenter@oracle.com \
--cc=jack_wang@usish.com \
--cc=linux-scsi@vger.kernel.org \
--cc=santoshprasadnayak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox