From: Matthew Wilcox <matthew@wil.cx>
To: santosh nayak <santoshprasadnayak@gmail.com>
Cc: JBottomley@parallels.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
mkp@mkp.net
Subject: Re: [PATCH] [SCSI] sd: set BIO_MAPPED_INTEGRITY bit correctly in sd_dif_prepare().
Date: Wed, 7 Mar 2012 08:56:25 -0700 [thread overview]
Message-ID: <20120307155624.GC19570@parisc-linux.org> (raw)
In-Reply-To: <1331131295-3707-1-git-send-email-santoshprasadnayak@gmail.com>
On Wed, Mar 07, 2012 at 08:11:35PM +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> Value of BIO_MAPPED_INTEGRITY is 11. Intention was to set the 11th bit.
Also, can we introduce:
#define bio_set_flag(bio, flag) ((bio)->bi_flags |= (1 << (flag)))
Then hunt down and kill all the places that manipulate bi_flags by hand?
We might also need:
#define bio_set_flag_atomic(bio, flag) set_bit(&(bio)->bi_flags, (flag))
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2012-03-07 15:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 14:41 [PATCH] [SCSI] sd: set BIO_MAPPED_INTEGRITY bit correctly in sd_dif_prepare() santosh nayak
2012-03-07 15:44 ` Matthew Wilcox
2012-03-07 15:56 ` Matthew Wilcox [this message]
2012-03-07 15:59 ` santosh prasad nayak
2012-03-07 16:07 ` santosh prasad nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307155624.GC19570@parisc-linux.org \
--to=matthew@wil.cx \
--cc=JBottomley@parallels.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@mkp.net \
--cc=santoshprasadnayak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox