Re: [PATCH] [SCSI] pm8001: fix endian issue with code optimization.

walter harms
2012-03-07T15:58:36Z

Am 07.03.2012 16:11, schrieb Mark Salyzyn:
> One more NAK:
>
>> @@ -3497,7 +3499,7 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void* piomb)
>> static void process_one_iomb(struct pm8001_hba_info *pm8001_ha, void *piomb)
>> {
>> u32 pHeader = (u32)*(u32 *)piomb;
>> - u8 opc = (u8)((le32_to_cpu(pHeader)) & 0xFFF);
>> + u8 opc = (u8)(pHeader & 0xFFF);
>>
>> PM8001_MSG_DBG(pm8001_ha, pm8001_printk("process_one_iomb:"));
>
> The swap is necessary. Should be:
>
> __le32 pHeader = (__le32)*(__le32 *)piomb;
>
> instead ...
>

hi,

would it help to make piomb __le32 instead of void ?

Also i do not understand what want to gain from 0xFFF
Doing (u8) is effectively doing & 0xFF.

re,
wh