Re: [PATCH 0/4] FCoE Sysfs

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Mar 12, 2012 at 04:09:15PM -0700, Robert Love wrote:
> This patch series adds a sysfs layer to libfcoe. It adds
> a sysfs instance for FIP controllers (a SW entity) and
> discovered Fibre Channel Forwarders (FCFs), which are
> simply FCoE switches.
> 
> The new sysfs code is used by any driver that currently
> uses libfcoe, namely fcoe.ko and bnx2fc_fcoe.ko. Any other
> FCoE capable device that wishes to use the high-level APIs
> defined in fcoe_syfs.h may, without having to use the
> the protocol processing portions of libfcoe.
> 
> The code borrows heavily from the FC Transport, but is
> less complicated because it does not need to interact
> with the SCSI layer directly.
> 
> I think one thing to consider with this series is that
> drivers, such as traditional HBAs, which wish to use
> this infrastructure will now need to depend on libfcoe.ko.
> It was either this or create a superfluous kernel module;
> I think libfcoe is an appropriate place for this code.
> 
> This series was created against scsi-misc + 9 patches
> mailed by me to linux-scsi on 03/09/12. (Note that 10
> patches were mailed, but that patch 01/10 will be dropped)
> 
> I'm not sure if there's somewhere I should cross-post
> this for general sysfs review. I don't think I'm doing
> anything odd; I added Greg K-H to the CC list to try and
> get some sysfs eyes on this code.

As you are adding new sysfs files, please always add the proper
Documentation/ABI/ files as well.

thanks,

greg k-h