From: Greg KH <gregkh@linuxfoundation.org>
To: Robert Love <robert.w.love@intel.com>
Cc: linux-scsi@vger.kernel.org, james.smart@emulex.com,
giridhar.malavali@qlogic.com
Subject: Re: [PATCH 3/4] libfcoe: Add fcoe_sysfs
Date: Mon, 12 Mar 2012 22:00:13 -0700 [thread overview]
Message-ID: <20120313050013.GB15426@kroah.com> (raw)
In-Reply-To: <20120312230931.10580.58845.stgit@localhost6.localdomain6>
On Mon, Mar 12, 2012 at 04:09:31PM -0700, Robert Love wrote:
> +static void fcoe_ctlr_attrs_release(struct device *dev)
> +{
> + struct fcoe_ctlr_attrs *ctlr = dev_to_ctlr(dev);
> +
> + put_device(ctlr->dev.parent);
> + ctlr->dev.parent = NULL;
You should never have to put a reference count on your parent, nor worry
about setting this value to NULL. Just assign the parent when you
register the device, no need to increment it.
> +#define fcoe_ctlr_id(x) \
> + ((x)->id)
> +#define fcoe_ctlr_work_q_name(x) \
> + ((x)->work_q_name)
<snip>
Ick, what are all of these for, please don't do that.
thanks,
greg k-h
next prev parent reply other threads:[~2012-03-13 5:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 23:09 [PATCH 0/4] FCoE Sysfs Robert Love
2012-03-12 23:09 ` [PATCH 1/4] fcoe: Allocate fcoe_ctlr with fcoe_interface, not as a member Robert Love
2012-03-12 23:09 ` [PATCH 2/4] bnx2fc: Allocate fcoe_ctlr with bnx2fc_interface, " Robert Love
2012-03-12 23:09 ` [PATCH 3/4] libfcoe: Add fcoe_sysfs Robert Love
2012-03-13 5:00 ` Greg KH [this message]
2012-03-14 1:19 ` Love, Robert W
2012-03-14 2:42 ` Greg KH
2012-03-12 23:09 ` [PATCH 4/4] fcoe, bnx2fc, libfcoe: SW FCoE and bnx2fc use FCoE Syfs Robert Love
2012-03-13 4:56 ` [PATCH 0/4] FCoE Sysfs Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313050013.GB15426@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=giridhar.malavali@qlogic.com \
--cc=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
--cc=robert.w.love@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox