From: Dan Carpenter <dan.carpenter@oracle.com>
To: nab@linux-iscsi.org
Cc: linux-driver@qlogic.com, linux-scsi@vger.kernel.org
Subject: re: qla2xxx: Enable >= 24xx target-mode support in SCSI LLD
Date: Tue, 13 Mar 2012 20:20:16 +0300 [thread overview]
Message-ID: <20120313172016.GC31808@elgon.mountain> (raw)
Hello Nicholas,
The patch bb52e091fe63: "qla2xxx: Enable >= 24xx target-mode support
in SCSI LLD" from Mar 8, 2012, leads to the following Smatch warning:
drivers/scsi/qla2xxx/qla_mbx.c:1458 qla2x00_get_port_database()
error: potential null derefence 'pd24'.
drivers/scsi/qla2xxx/qla_mbx.c
1456
1457 /* If not target must be initiator or unknown type. */
1458 if ((pd24->prli_svc_param_word_3[0] & BIT_4))
^^^^^^
1459 fcport->port_type = FCT_TARGET;
1460 else if ((pd24->prli_svc_param_word_3[0] & BIT_5))
^^^^^^
These are always NULL here.
1461 fcport->port_type = FCT_INITIATOR;
1462
regards,
dan carpenter
next reply other threads:[~2012-03-13 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 17:20 Dan Carpenter [this message]
2012-03-15 22:59 ` qla2xxx: Enable >= 24xx target-mode support in SCSI LLD Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313172016.GC31808@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-driver@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox