From: Dan Carpenter <dan.carpenter@oracle.com>
To: nab@linux-iscsi.org
Cc: linux-scsi@vger.kernel.org, linux-driver@qlogic.com
Subject: qla2xxx: NULL deref in qla_tgt_abort_task()
Date: Tue, 13 Mar 2012 20:21:40 +0300 [thread overview]
Message-ID: <20120313172140.GF31808@elgon.mountain> (raw)
Hello Nicholas,
This is a semi-automatic email about new static checker warnings.
The patch 962f988d031f: "qla2xxx: Add LLD target-mode infrastructure
for >= 24xx series" from Mar 8, 2012, leads to the following Smatch
complaint:
drivers/scsi/qla2xxx/qla_target.c:2873 qla_tgt_abort_task()
error: we previously assumed 'sess' could be null (see line 2870)
drivers/scsi/qla2xxx/qla_target.c
2869 sess = ha->tgt_ops->find_sess_by_loop_id(vha, loop_id);
2870 if (sess == NULL) {
^^^^^^^^^^^^
Test.
2871 ql_dbg(ql_dbg_tgt_mgt, vha, 0xe129, "qla_target(%d): task abort for unexisting "
2872 "session\n", vha->vp_idx);
2873 res = qla_tgt_sched_sess_work(sess->tgt, QLA_TGT_SESS_WORK_ABORT,
^^^^^^^^^
NULL dereference.
2874 iocb, sizeof(*iocb));
2875 if (res != 0)
regards,
dan carpenter
next reply other threads:[~2012-03-13 17:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 17:21 Dan Carpenter [this message]
2012-03-15 23:24 ` qla2xxx: NULL deref in qla_tgt_abort_task() Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313172140.GF31808@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-driver@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox