* [PATCH] mpt2sas: Fix hex/decimal typo in _base_sas_log_info()
@ 2012-03-14 3:56 Chris Dunlop
2012-03-14 18:08 ` Chris Dunlop
0 siblings, 1 reply; 2+ messages in thread
From: Chris Dunlop @ 2012-03-14 3:56 UTC (permalink / raw)
To: James E.J. Bottomley, Nandigama, Nagalakshmi, Kashyap Desai,
James Bottomley, linux-scsi, linux-kernel
The log_info constant is supposed to be IOP_LOGINFO_CODE_TASK_TERMINATED
(see drivers/message/fusion/lsi/mpi_log_sas.h) rather than the
non-sensical 0x1CA86D0.
Signed-off-by: Chris Dunlop <chris@onthe.net.au>
---
drivers/scsi/mpt2sas/mpt2sas_base.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
index a78036f..224ed29 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_base.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
@@ -657,7 +657,7 @@ _base_sas_log_info(struct MPT2SAS_ADAPTER *ioc , u32 log_info)
return;
/* eat the loginfos associated with task aborts */
- if (ioc->ignore_loginfos && (log_info == 30050000 || log_info ==
+ if (ioc->ignore_loginfos && (log_info == 0x30050000 || log_info ==
0x31140000 || log_info == 0x31130000))
return;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mpt2sas: Fix hex/decimal typo in _base_sas_log_info()
2012-03-14 3:56 [PATCH] mpt2sas: Fix hex/decimal typo in _base_sas_log_info() Chris Dunlop
@ 2012-03-14 18:08 ` Chris Dunlop
0 siblings, 0 replies; 2+ messages in thread
From: Chris Dunlop @ 2012-03-14 18:08 UTC (permalink / raw)
To: James E.J. Bottomley, Nandigama, Nagalakshmi, Kashyap Desai,
James Bottomley, linux-scsi, linux-kernel, sathisha.nanjappa
On Wed, Mar 14, 2012 at 02:56:10PM +1100, Chris Dunlop wrote:
> The log_info constant is supposed to be IOP_LOGINFO_CODE_TASK_TERMINATED
> (see drivers/message/fusion/lsi/mpi_log_sas.h) rather than the
> non-sensical 0x1CA86D0.
Oops, I see Sathisha Nanjappa has already submitted this fix:
http://article.gmane.org/gmane.linux.scsi/73446
> Signed-off-by: Chris Dunlop <chris@onthe.net.au>
> ---
> drivers/scsi/mpt2sas/mpt2sas_base.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
> index a78036f..224ed29 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_base.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
> @@ -657,7 +657,7 @@ _base_sas_log_info(struct MPT2SAS_ADAPTER *ioc , u32 log_info)
> return;
>
> /* eat the loginfos associated with task aborts */
> - if (ioc->ignore_loginfos && (log_info == 30050000 || log_info ==
> + if (ioc->ignore_loginfos && (log_info == 0x30050000 || log_info ==
> 0x31140000 || log_info == 0x31130000))
> return;
>
> --
> 1.7.0.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-14 18:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-14 3:56 [PATCH] mpt2sas: Fix hex/decimal typo in _base_sas_log_info() Chris Dunlop
2012-03-14 18:08 ` Chris Dunlop
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox