From: Chris Dunlop <chris@onthe.net.au>
To: "James E.J. Bottomley" <JBottomley@parallels.com>,
"Nandigama, Nagalakshmi" <Nagalakshmi.Nandigama@lsi.com>,
Kashyap Desai <kashyap.desai@lsi.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
sathisha.nanjappa@hp.com
Subject: Re: [PATCH] mpt2sas: Fix hex/decimal typo in _base_sas_log_info()
Date: Thu, 15 Mar 2012 05:08:22 +1100 [thread overview]
Message-ID: <20120314180822.GA29954@onthe.net.au> (raw)
In-Reply-To: <20120314035610.GA21520@onthe.net.au>
On Wed, Mar 14, 2012 at 02:56:10PM +1100, Chris Dunlop wrote:
> The log_info constant is supposed to be IOP_LOGINFO_CODE_TASK_TERMINATED
> (see drivers/message/fusion/lsi/mpi_log_sas.h) rather than the
> non-sensical 0x1CA86D0.
Oops, I see Sathisha Nanjappa has already submitted this fix:
http://article.gmane.org/gmane.linux.scsi/73446
> Signed-off-by: Chris Dunlop <chris@onthe.net.au>
> ---
> drivers/scsi/mpt2sas/mpt2sas_base.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
> index a78036f..224ed29 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_base.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
> @@ -657,7 +657,7 @@ _base_sas_log_info(struct MPT2SAS_ADAPTER *ioc , u32 log_info)
> return;
>
> /* eat the loginfos associated with task aborts */
> - if (ioc->ignore_loginfos && (log_info == 30050000 || log_info ==
> + if (ioc->ignore_loginfos && (log_info == 0x30050000 || log_info ==
> 0x31140000 || log_info == 0x31130000))
> return;
>
> --
> 1.7.0.4
>
prev parent reply other threads:[~2012-03-14 18:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 3:56 [PATCH] mpt2sas: Fix hex/decimal typo in _base_sas_log_info() Chris Dunlop
2012-03-14 18:08 ` Chris Dunlop [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120314180822.GA29954@onthe.net.au \
--to=chris@onthe.net.au \
--cc=JBottomley@parallels.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Nagalakshmi.Nandigama@lsi.com \
--cc=kashyap.desai@lsi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sathisha.nanjappa@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox