From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [libsas PATCH v12 04/11] sysfs: handle 'parent deleted before child added'
Date: Thu, 22 Mar 2012 23:51:33 +0100 [thread overview]
Message-ID: <20120322235133.269b74b8@stein> (raw)
In-Reply-To: <CABE8wwtyxJaSfZREKRLDTZEef3nk=b+RFSe9i_UmV9knbQJ-tg@mail.gmail.com>
On Mar 22 Williams, Dan J wrote:
> On Thu, Mar 22, 2012 at 7:39 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Wed, Mar 21, 2012 at 11:32:14PM -0700, Dan Williams wrote:
> [..]
> >> diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
> >> index 7fdf6a7..86521ee 100644
> >> --- a/fs/sysfs/dir.c
> >> +++ b/fs/sysfs/dir.c
> >> @@ -714,6 +714,9 @@ int sysfs_create_dir(struct kobject * kobj)
> >> else
> >> parent_sd = &sysfs_root;
> >>
> >> + if (!parent_sd)
> >> + return -ENOENT;
> >> +
> >> if (sysfs_ns_type(parent_sd))
> >> ns = kobj->ktype->namespace(kobj);
> >> type = sysfs_read_ns_type(kobj);
> >
> > So what happens if this is true? Does this patch fix the oops?
>
> This patch downgrades the oops by turning it into a device_add()
> failure, but the patches that *fix* this warning are here [1] and here
> [2].
[...]
> [1]: http://marc.info/?l=linux-scsi&m=133239707903443&w=2
> [2]: http://marc.info/?l=linux-scsi&m=133239709603452&w=2
Isn't this something which is to be accomplished by counting references to
the parent device?
--
Stefan Richter
-=====-===-- --== =-==-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2012-03-22 22:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 6:31 [libsas PATCH v12 00/11] libsas eh, discovery, suspend, and fixes Dan Williams
2012-03-22 6:31 ` [libsas PATCH v12 01/11] libsas: cleanup spurious calls to scsi_schedule_eh Dan Williams
2012-03-22 6:32 ` [libsas PATCH v12 02/11] libsas: trim sas_task of slow path infrastructure Dan Williams
2012-03-22 6:32 ` [libsas PATCH v12 03/11] libata: reset once Dan Williams
2012-03-22 6:32 ` [libsas PATCH v12 04/11] sysfs: handle 'parent deleted before child added' Dan Williams
2012-03-22 14:39 ` Greg Kroah-Hartman
2012-03-22 16:27 ` Williams, Dan J
2012-03-22 22:51 ` Stefan Richter [this message]
2012-03-22 23:11 ` Williams, Dan J
2012-03-22 23:26 ` Stefan Richter
2012-03-23 18:43 ` Dan Williams
2012-03-23 20:54 ` Greg Kroah-Hartman
2012-03-23 21:15 ` Williams, Dan J
2012-03-22 14:47 ` James Bottomley
2012-03-22 16:34 ` Williams, Dan J
2012-03-22 6:32 ` [libsas PATCH v12 05/11] scsi_transport_sas: fix delete vs scan race Dan Williams
2012-03-22 6:32 ` [libsas PATCH v12 06/11] libsas: unify domain_device sas_rphy lifetimes Dan Williams
2012-03-22 6:32 ` [libsas PATCH v12 07/11] libsas: fix false positive 'device attached' conditions Dan Williams
2012-03-22 6:32 ` [libsas PATCH v12 08/11] libsas: fix ata_eh clobbering ex_phys via smp_ata_check_ready Dan Williams
2012-03-22 6:32 ` [libsas PATCH v12 09/11] libsas, libata: fix start of life for a sas ata_port Dan Williams
2012-03-22 6:32 ` [libsas PATCH v12 10/11] scsi, sd: limit the scope of the async probe domain Dan Williams
2012-03-22 14:20 ` Alan Stern
2012-03-22 19:09 ` Williams, Dan J
2012-03-22 6:32 ` [libsas PATCH v12 11/11] libsas: suspend / resume support Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322235133.269b74b8@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).