From: Mike Snitzer <snitzer@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: linux-scsi@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [PATCH 2/2] dm-mpath: Allow 'default' hardware handler
Date: Mon, 2 Apr 2012 13:04:26 -0400 [thread overview]
Message-ID: <20120402170426.GA28901@redhat.com> (raw)
In-Reply-To: <1333385035-6663-3-git-send-email-hare@suse.de>
On Mon, Apr 02 2012 at 12:43pm -0400,
Hannes Reinecke <hare@suse.de> wrote:
> This patch introduces a 'default' hardware handler for dm-mpath.
> When specifying '1 default' dm-multipath will be using the currently
> attached hardware handler.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
> drivers/md/dm-mpath.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
> index 922a338..bbf950f 100644
> --- a/drivers/md/dm-mpath.c
> +++ b/drivers/md/dm-mpath.c
> @@ -586,15 +586,19 @@ static struct pgpath *parse_path(struct dm_arg_set *as, struct path_selector *ps
>
> if (m->hw_handler_name) {
> struct request_queue *q = bdev_get_queue(p->path.dev->bdev);
> + char *hw_handler = NULL;
>
> - r = scsi_dh_attach(q, m->hw_handler_name);
> + if (strncmp(m->hw_handler_name, "default", 6))
> + hw_handler = m->hw_handler_name;
Should be: if (strncmp(m->hw_handler_name, "default", 7))
next prev parent reply other threads:[~2012-04-02 17:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 16:43 [PATCH 0/2] 'default' hardware handler for multipath Hannes Reinecke
2012-04-02 16:43 ` [PATCH 1/2] scsi_dh: Allow NULL hardware handler name in scsi_dh_attach() Hannes Reinecke
2012-04-02 17:06 ` Mike Snitzer
2012-04-03 1:46 ` [dm-devel] " Jun'ichi Nomura
2012-04-02 16:43 ` [PATCH 2/2] dm-mpath: Allow 'default' hardware handler Hannes Reinecke
2012-04-02 17:04 ` Mike Snitzer [this message]
2012-04-02 17:07 ` Hannes Reinecke
2012-04-03 1:45 ` [dm-devel] " Jun'ichi Nomura
2012-04-03 21:12 ` [dm-devel] [PATCH 0/2] 'default' hardware handler for multipath Moger, Babu
2012-04-18 14:07 ` Hannes Reinecke
2012-04-18 16:25 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120402170426.GA28901@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).