From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: James Bottomley <JBottomley@parallels.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 1/2] sysfs: handle 'parent deleted before child added'
Date: Fri, 6 Apr 2012 13:45:14 -0700 [thread overview]
Message-ID: <20120406204514.GA20237@kroah.com> (raw)
In-Reply-To: <20120406203619.22624.69445.stgit@dwillia2-linux.jf.intel.com>
On Fri, Apr 06, 2012 at 01:41:06PM -0700, Dan Williams wrote:
> In scsi at least two cases of the parent device being deleted before the
> child is added have been observed.
>
> 1/ scsi is performing async scans and the device is removed prior to the
> async can thread running (can happen with an in-opportune / unlikely
> unplug during initial scan).
That sounds like a bug in the scsi code, doesn't it?
> 2/ libsas discovery event running after the parent port has been torn
> down (this is a bug in libsas).
Is this fixed somewhere?
I don't want to paper over bugs like this by changing the sysfs core.
We went through this a lot years ago when scsi changed to use the driver
core, and I thought we had fixed all of these types of errors properly.
So, any chance to fix these properly as well?
thanks,
greg k-h
next prev parent reply other threads:[~2012-04-06 20:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 20:41 [PATCH v2 1/2] sysfs: handle 'parent deleted before child added' Dan Williams
2012-04-06 20:41 ` [PATCH v2 2/2] sysfs: provide more diagnostic info for kobject_add_internal() failures Dan Williams
2012-04-06 20:45 ` Greg KH [this message]
2012-04-06 21:06 ` [PATCH v2 1/2] sysfs: handle 'parent deleted before child added' Williams, Dan J
2012-04-06 21:17 ` Greg KH
2012-04-06 21:44 ` Williams, Dan J
2012-04-06 22:11 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120406204514.GA20237@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=JBottomley@parallels.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).