From: Vivek Goyal <vgoyal@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
Moyer Jeff Moyer <jmoyer@redhat.com>,
linux-scsi@vger.kernel.org, kay.sievers@vrfy.org
Subject: Re: [RFC PATCH] block: Change default IO scheduler to deadline except SATA
Date: Tue, 10 Apr 2012 15:11:21 -0400 [thread overview]
Message-ID: <20120410191121.GM21801@redhat.com> (raw)
In-Reply-To: <4F848253.6060303@kernel.dk>
On Tue, Apr 10, 2012 at 08:56:19PM +0200, Jens Axboe wrote:
> On 2012-04-10 20:53, Vivek Goyal wrote:
> > On Tue, Apr 10, 2012 at 08:41:08PM +0200, Jens Axboe wrote:
> >
> > [..]
> >>> So we are back to the question of can scsi devices find out if a Lun
> >>> is backed by single disk or multiple disks.
> >>
> >> The cleanest would be to have the driver signal these attributes at
> >> probe time. You could even adjust CFQ properties based on this, driving
> >> the queue depth harder etc. Realistically, going forward, most fast
> >> flash devices will be driven by a noop-like scheduler on multiqueue. So
> >> CPU cost of the IO scheduler can mostly be ignored, since CFQ cost on
> >> even big RAIDs isn't an issue due to the low IOPS rates.
> >
> > Agreed that on RAID CPU cost is not a problem. Just that idling and low
> > queue depth kills the performance.
>
> Exactly, and both of these are trivially adjustable as long as we know
> when to do it.
>
> > So apart from "rotational" if driver can give some hints about underlying
> > devices being RAID (or multi device), it will help. Just that it looks
> > like scsi does not have a way to determine that.
>
> This sort of thing should be done with a udev rule.
[CCing kay]
Kay does not like the idea of doing something along this line in udev.
He thinks that kernel changes over a period of time making udev rules
stale and hence it should be done in kernel. :-) I think he has had
some not so good experiences in the past.
Though personally I think that anything which is not set in stone should
go to udev. It atleast allows for easy change if user does not like the
setting. (disable the rule, modify the rule etc). And then rules evolve
as things change in kernel.
Anyway, this point can be detabted later once we figure out what's the
set of atrributes to look at.
> It should not be too
> hard to match for the most popular arrays, catching the majority of the
> setups by default. Or you could ask the SCSI folks for some heuristics,
> it's not unlikely that a few different attributes could make that bullet
> proof, pretty much.
I am wondering what will happen to request based multipath targets in
this scheme. There will have to be I guess additional rules to look for
underlying paths and then change the io scheduler accordingly.
CCing linux-scsi, if scsi guys have some ideas on what can we look at to
determine what scheduler to use.
Thanks
Vivek
next parent reply other threads:[~2012-04-10 19:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120410133708.GE21801@redhat.com>
[not found] ` <4F843C17.5050004@kernel.dk>
[not found] ` <20120410142148.GG21801@redhat.com>
[not found] ` <20120410151042.GH21801@redhat.com>
[not found] ` <4F847EC4.7040604@kernel.dk>
[not found] ` <20120410185318.GL21801@redhat.com>
[not found] ` <4F848253.6060303@kernel.dk>
2012-04-10 19:11 ` Vivek Goyal [this message]
2012-04-10 19:19 ` [RFC PATCH] block: Change default IO scheduler to deadline except SATA Jens Axboe
2012-04-10 19:43 ` Mike Snitzer
2012-04-10 19:55 ` Jens Axboe
2012-04-10 20:12 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410191121.GM21801@redhat.com \
--to=vgoyal@redhat.com \
--cc=axboe@kernel.dk \
--cc=jmoyer@redhat.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).