From: Tejun Heo <tj@kernel.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: Problems with sr_get_events
Date: Tue, 17 Apr 2012 08:38:22 -0700 [thread overview]
Message-ID: <20120417153822.GD32402@google.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1204171128580.1364-100000@iolanthe.rowland.org>
On Tue, Apr 17, 2012 at 11:33:27AM -0400, Alan Stern wrote:
> > Hmmm... Maybe but we've been sending GET_EVENT without such provision
> > for very long time now. I feel reluctant to change something which
> > seems to work in this area even if that something is technically
> > wrong. It's not like cheap USB devices tend to be technically correct
> > anyway.
>
> All right, then how do you feel about this patch? It makes minimal
> changes, to avoid the inefficiency of sending repeated commands that
> can never work.
Hmmm... while I don't object to the patch per-se, I'm not sure what
benefit it brings. Do you have any specific case where this is
necessary / beneficial? What are we gaining by not issuing GET_EVENT?
Thanks.
--
tejun
next prev parent reply other threads:[~2012-04-17 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-08 13:24 Problems with sr_get_events Alan Stern
2012-04-16 22:55 ` Tejun Heo
2012-04-17 15:33 ` Alan Stern
2012-04-17 15:38 ` Tejun Heo [this message]
2012-04-17 15:46 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417153822.GD32402@google.com \
--to=tj@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox