From: Mike Snitzer <snitzer@redhat.com>
To: James.Bottomley@hansenpartnership.com
Cc: linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
Chandra Seetharaman <sekharan@us.ibm.com>,
linux-kernel@vger.kernel.org
Subject: [RESEND][PATCH] [SCSI] scsi_dh: allow 3rd party multipath drivers to use scsi_dh_detach
Date: Fri, 20 Apr 2012 10:45:38 -0400 [thread overview]
Message-ID: <20120420144538.GB8155@redhat.com> (raw)
In-Reply-To: <20120405144721.GA18437@redhat.com>
Allow 3rd party multipath drivers to programatically detach a scsi_dh
using the scsi_dh_detach() interface. This is as improvement over
requiring them to write 'detach' to /sys/block/sdX/queue/dh_state
End result is both Linux and 3rd party multipath drivers can coexist
without compromising Linux's default handling of multipath LUNs.
Linux has suffered from races associated with attaching a scsi_dh to a
device too late (after an HBA driver has started the SCSI device scan).
Attaching a scsi_dh too late results in default sense handling that does
not silently fail IO to passive paths, which creates excessive delays
and IO errors during normal boot on a system with hundreds of LUNs.
To fix this the appropriate scsi_dh must be attached before the HBA
driver(s) are even loaded. But some scsi_dh are known to conflict with
3rd party multipath drivers (e.g. both scsi_dh_alua and scsi_dh_emc
conflict with EMC PowerPath). This patch allows 3rd party drivers to
resolve the conflict by detaching an attached scsi_dh.
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Acked-by: Hannes Reinecke <hare@suse.de>
Cc: Chandra Seetharaman <sekharan@us.ibm.com>
---
drivers/scsi/device_handler/scsi_dh.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/device_handler/scsi_dh.c b/drivers/scsi/device_handler/scsi_dh.c
index 23149b9..a550de1 100644
--- a/drivers/scsi/device_handler/scsi_dh.c
+++ b/drivers/scsi/device_handler/scsi_dh.c
@@ -578,7 +578,7 @@ void scsi_dh_detach(struct request_queue *q)
}
put_device(&sdev->sdev_gendev);
}
-EXPORT_SYMBOL_GPL(scsi_dh_detach);
+EXPORT_SYMBOL(scsi_dh_detach);
static struct notifier_block scsi_dh_nb = {
.notifier_call = scsi_dh_notifier
next prev parent reply other threads:[~2012-04-20 14:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 21:44 [RFC PATCH] scsi_dh: allow 3rd party multipath drivers to scsi_dh_detach Mike Snitzer
2011-12-20 7:31 ` Hannes Reinecke
2012-01-05 15:24 ` Mike Snitzer
2012-04-05 14:47 ` Mike Snitzer
2012-04-20 14:45 ` Mike Snitzer [this message]
2012-04-20 15:17 ` [RESEND][PATCH] [SCSI] scsi_dh: allow 3rd party multipath drivers to use scsi_dh_detach James Bottomley
2012-04-20 15:46 ` Mike Snitzer
2012-04-20 15:49 ` Chandra Seetharaman
2012-04-20 17:34 ` [PATCH v2] [SCSI] scsi_dh: change scsi_dh_detach export to EXPORT_SYMBOL Mike Snitzer
2012-04-20 20:41 ` Alan Cox
2012-04-20 21:58 ` Mike Snitzer
2012-04-20 22:20 ` Alan Cox
2012-04-20 22:58 ` Mike Snitzer
2012-04-20 23:14 ` Alan Cox
2012-04-20 23:34 ` Mike Snitzer
2012-04-22 22:13 ` Mike Snitzer
2012-04-22 22:34 ` Alan Cox
2012-04-22 23:01 ` Mike Snitzer
2012-04-22 23:13 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120420144538.GB8155@redhat.com \
--to=snitzer@redhat.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sekharan@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).