From: Dan Carpenter <dan.carpenter@oracle.com>
To: kgudipat@brocade.com
Cc: linux-scsi@vger.kernel.org
Subject: re: [SCSI] bfa: Fix to defer vport delete handler invocation till firmware logo response.
Date: Mon, 30 Apr 2012 11:20:58 +0300 [thread overview]
Message-ID: <20120430082058.GA4459@elgon.mountain> (raw)
Hello Krishna Gudipati,
This is a semi-automatic email about new static checker warnings.
The patch 17c201b3281c: "[SCSI] bfa: Fix to defer vport delete
handler invocation till firmware logo response." from Apr 9, 2012,
leads to the following Smatch complaint:
drivers/scsi/bfa/bfa_fcs_lport.c:5725 bfa_fcs_vport_free()
warn: variable dereferenced before check 'vport_drv' (see line 5715)
drivers/scsi/bfa/bfa_fcs_lport.c
5714
5715 if (vport_drv->comp_del) {
^^^^^^^^^^^^^^^^^^^
Old dereference.
5716 complete(vport_drv->comp_del);
5717 return;
5718 }
5719
5720 /*
5721 * We queue the vport delete work to the IM work_q from here.
5722 * The memory for the bfad_vport_s is freed from the FC function
5723 * template vport_delete entry point.
5724 */
5725 if (vport_drv)
^^^^^^^^^
New check.
5726 bfad_im_port_delete(vport_drv->drv_port.bfad,
5727 &vport_drv->drv_port);
regards,
dan carpenter
reply other threads:[~2012-04-30 8:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120430082058.GA4459@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kgudipat@brocade.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).