* [patch] target: lock => unlock typo
@ 2012-05-08 10:28 Dan Carpenter
2012-05-08 14:35 ` Christoph Hellwig
2012-05-09 2:28 ` Nicholas A. Bellinger
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2012-05-08 10:28 UTC (permalink / raw)
To: Nicholas A. Bellinger, Christoph Hellwig
Cc: linux-scsi, target-devel, kernel-janitors
target_stop_cmd() returns with the lock held and IRQs disabled. The
intent was to unlock here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index 0d838ab..8bd9ffe 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -3769,7 +3769,7 @@ static int transport_lun_wait_for_tasks(struct se_cmd *cmd, struct se_lun *lun)
(cmd->transport_state & CMD_T_SENT)) {
if (!target_stop_cmd(cmd, &flags))
ret++;
- spin_lock_irqsave(&cmd->t_state_lock, flags);
+ spin_unlock_irqrestore(&cmd->t_state_lock, flags);
} else {
spin_unlock_irqrestore(&cmd->t_state_lock,
flags);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] target: lock => unlock typo
2012-05-08 10:28 [patch] target: lock => unlock typo Dan Carpenter
@ 2012-05-08 14:35 ` Christoph Hellwig
2012-05-09 2:28 ` Nicholas A. Bellinger
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2012-05-08 14:35 UTC (permalink / raw)
To: Dan Carpenter
Cc: Nicholas A. Bellinger, Christoph Hellwig, linux-scsi,
target-devel, kernel-janitors
Looks good, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] target: lock => unlock typo
2012-05-08 10:28 [patch] target: lock => unlock typo Dan Carpenter
2012-05-08 14:35 ` Christoph Hellwig
@ 2012-05-09 2:28 ` Nicholas A. Bellinger
1 sibling, 0 replies; 3+ messages in thread
From: Nicholas A. Bellinger @ 2012-05-09 2:28 UTC (permalink / raw)
To: Dan Carpenter
Cc: Christoph Hellwig, linux-scsi, target-devel, kernel-janitors
On Tue, 2012-05-08 at 13:28 +0300, Dan Carpenter wrote:
> target_stop_cmd() returns with the lock held and IRQs disabled. The
> intent was to unlock here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index 0d838ab..8bd9ffe 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -3769,7 +3769,7 @@ static int transport_lun_wait_for_tasks(struct se_cmd *cmd, struct se_lun *lun)
> (cmd->transport_state & CMD_T_SENT)) {
> if (!target_stop_cmd(cmd, &flags))
> ret++;
> - spin_lock_irqsave(&cmd->t_state_lock, flags);
> + spin_unlock_irqrestore(&cmd->t_state_lock, flags);
> } else {
> spin_unlock_irqrestore(&cmd->t_state_lock,
> flags);
> --
Applied to lio-core, and folding into hch's original commit that
introduced the bug in for-next.
Thanks Dan!
--nab
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-09 2:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-08 10:28 [patch] target: lock => unlock typo Dan Carpenter
2012-05-08 14:35 ` Christoph Hellwig
2012-05-09 2:28 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox